fix(hwpx): 그림 effects/shadow roundtrip 보존#1349
Closed
Mireutale wants to merge 1 commit into
Closed
Conversation
Owner
|
검토 및 수용 완료했습니다. PR 커밋은 현재 devel 기준으로 maintainer-side cherry-pick 하여 반영했습니다. 로컬 검증:
HWPX effects/shadow roundtrip 보존 방향과 hp:container 자식 직렬화 보강이 타당함을 확인했습니다. hwpx2hwp 저장 경로도 별도 cross-check 했고, HWP export/reload 경로를 깨뜨리지 않는 것을 확인했습니다. 기여 감사합니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 요약
HWPX 그림의
hp:effects/hp:shadow정보가 parse → serialize_hwpx roundtrip 중 사라지는 문제를 수정했습니다.PictureIR에 HWPX 그림 효과 모델(PictureEffects,PictureShadow,EffectColor등)을 추가했습니다.hp:effects > hp:shadow > hp:scale/effectsColor/rgb값을 보존하도록 했습니다.hp:container안의 그룹 자식 그림도 직렬화되도록 그룹 자식 루프를 연결했습니다.samples/hwpx/aift.hwpx기반 roundtrip 회귀 테스트를 추가했습니다.관련 이슈
closes #1345
테스트
git diff --check통과cargo fmt --all -- --check통과cargo test --lib issue_1345_picture_effects_shadow_roundtrip통과cargo test --lib picture_effects_shadow_are_serialized통과cargo clippy --lib -- -D warnings통과cargo test통과스크린샷
XML roundtrip 데이터 보존 수정이라 스크린샷은 첨부하지 않았습니다.