Task #1187: BookReview.hwp 글상자 내용 clip 회귀 수정#1190
Merged
edwardkim merged 8 commits intoMay 31, 2026
Merged
Conversation
Owner
|
머지 완료했습니다 (devel 리뷰 요약문제 — 수정 확인
검증 (로컬 머지 시뮬레이션 + 머지 후 재검증)
golden SVG(issue-267/issue-617)는 TextBox clip 도입에 따른 의도적 변경으로 확인했습니다. |
edwardkim
added a commit
that referenced
this pull request
May 31, 2026
… by @postmelee) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈: #1187
요약
BookReview.hwp1쪽 글상자 콘텐츠를RenderNodeType::TextBox하위로 모아 SVG와 paint layer 양쪽에서 글상자 내부 영역으로 clip 되도록 수정했습니다.ClipKind::TextBox및 JSON"clipKind":"textBox"를 추가했고, additive 변경으로schemaMinorVersion을14 -> 15로 올렸습니다.line_seg.vertical_pos중복 적용을 막아 정상 표시되어야 하는5장,6장,에필로그목차 줄이 clip 안에 남도록 했습니다.svg_snapshot실패를 보정했습니다.layout_composed_paragraph에 명시 플래그를 추가해 표 셀의 기존 column-top vpos fallback 은 유지하고, 글상자 내부 문단에서만 중복 fallback 을 생략합니다.issue-267,issue-617SVG snapshot golden 을 갱신했습니다.시각 검증 스크린샷
검증
cargo fmt --all -- --checkgit diff --checkcargo build --bin rhwpcargo test --test svg_snapshot— 8 passedcargo test --test issue_1187_textbox_clip— 2 passedcargo test --lib paint::builder::tests— 7 passedcargo test --lib paint::json::tests::serializes_textbox_clip_kind— 1 passedcargo test --lib paint::schema::tests::layer_tree_schema_constants_match_schema— 1 passedcargo test --lib renderer::svg_layer::tests— 3 passedcargo test --test issue_1052_footnote_in_textbox --test issue_919_textbox_hit_test --test issue_1028_hwpx_textbox_vertical— 11 passedwasm-pack build --target web --devnpm run build— 통과, Vite chunk size 경고만 출력확인 메모
textbox-clip-33,textbox-clip-52,textbox-clip-103생성을 확인했습니다.textbox-clip-52(x=47.92,y=516.56,width=687.55,height=487.88) 아래에서 렌더링됩니다.1004.44이고, 보정 후5장,6장,에필로그baseline 은 각각887.34,924.03,960.73으로 clip 안에 남습니다.BookReview.hwp직접 로드 후 1쪽 하단 목차와 저자 정보 글상자 표시를 확인했습니다.