Merged
Conversation
cxw42
added a commit
to cxw42/editorconfig-core-test
that referenced
this pull request
Oct 30, 2022
- Hash in value is part of the value, not a comment - Backslashes before hashes or semicolons are part of the value as well, not an escaping mechanism. - This supersedes the change made in editorconfig#33. editorconfig/specification#31 (comment)
cxw42
added a commit
to cxw42/editorconfig-core-test
that referenced
this pull request
Oct 30, 2022
This implements the specification changes made by <editorconfig/specification#31>. - A hash or semicolon in a value is part of the value, not the beginning of a comment. - Backslashes before hashes or semicolons are part of the value as well, not an escaping mechanism. - This supersedes the change made in editorconfig#33.
xuhdev
pushed a commit
that referenced
this pull request
Oct 31, 2022
This implements the specification changes made by <editorconfig/specification#31>. - A hash or semicolon in a value is part of the value, not the beginning of a comment. - Backslashes before hashes or semicolons are part of the value as well, not an escaping mechanism. - This supersedes the change made in #33.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to the specification, which states:
We have no support or plans to support inline comments. The tests I am removing here are either related to inline comments or
:delimiters for key-value pairs, which is a Python ConfigParser feature for which EditorConfig has no purpose. It's also not in the specification.