feat: Add new Properties field to ProvisionWatcher DTO and Model#803
Merged
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom Feb 21, 2023
Merged
feat: Add new Properties field to ProvisionWatcher DTO and Model#803cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
Conversation
Add an extendable field into ProvisionWatcher DTO and Model: Properties map[string]any This is useful when certain device services requires extra information from ProvisionWatcher. For example, assume a device service would like to generate the device name in certain format during auto discovery, the user can define a property "DeviceNameTemplate" with value as the template of device name in the ProvisionWatcher, so that the device service can pick up such property to generate the device name. fixes edgexfoundry#772 Signed-off-by: Jude Hung <jude@iotechsys.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #803 +/- ##
==========================================
- Coverage 64.46% 64.39% -0.08%
==========================================
Files 80 80
Lines 3079 3084 +5
==========================================
+ Hits 1985 1986 +1
- Misses 905 908 +3
- Partials 189 190 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
judehung
added a commit
to judehung/edgex-docs
that referenced
this pull request
Feb 22, 2023
…isionWatcher dto Per edgexfoundry/go-mod-core-contracts#803 and edgexfoundry/go-mod-core-contracts#800, new fields `properties` are added into Device dto and ProvisionWatcher dto. This PR updates edgex-docs with the description of these new fields. Signed-off-by: Jude Hung <jude@iotechsys.com>
judehung
added a commit
to judehung/edgex-docs
that referenced
this pull request
Feb 22, 2023
…isionWatcher dto Per edgexfoundry/go-mod-core-contracts#803 and edgexfoundry/go-mod-core-contracts#800, new fields `properties` are added into Device dto and ProvisionWatcher dto. This PR updates edgex-docs with the description of these new fields. fixes edgexfoundry#969 Signed-off-by: Jude Hung <jude@iotechsys.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an extendable field into ProvisionWatcher DTO and Model:
Properties map[string]any. This is useful when certain device services requires extra information from ProvisionWatcher. For example, assume a device service would like to generate the device name in certain format during auto discovery, the user can define a property "DeviceNameTemplate" with value as the template of device name in the ProvisionWatcher, so that the device service can pick up such property to generate the device name.fixes #772
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)