refactor: Replace MergeValues with full reload in applyWritableUpdates#878
Merged
judehung merged 1 commit intoedgexfoundry:mainfrom Jul 3, 2025
Merged
refactor: Replace MergeValues with full reload in applyWritableUpdates#878judehung merged 1 commit intoedgexfoundry:mainfrom
judehung merged 1 commit intoedgexfoundry:mainfrom
Conversation
judehung
reviewed
Jul 2, 2025
|
|
||
| if err := utils.MergeValues(serviceConfig.GetWritablePtr(), raw); err != nil { | ||
| lc.Errorf("failed to apply Writable change to service configuration: %v", err) | ||
| serviceConfigCopy, err := copyConfigurationStruct(serviceConfig) |
Member
There was a problem hiding this comment.
this line causes unit test failure in https://jenkins.edgexfoundry.org/job/edgexfoundry/job/go-mod-bootstrap/job/PR-878/1/display/redirect
Signed-off-by: FelixTing <felix@iotechsys.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 46.40% 46.15% -0.26%
==========================================
Files 62 62
Lines 3644 3664 +20
==========================================
Hits 1691 1691
- Misses 1831 1851 +20
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FelixTing
added a commit
to FelixTing/go-mod-bootstrap
that referenced
this pull request
Oct 14, 2025
edgexfoundry#878) Signed-off-by: FelixTing <felix@iotechsys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #877 #534
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)