Skip to content

fix: Fix CoreCommand GET /device/all API incorrect totalCount#5174

Merged
judehung merged 1 commit intoedgexfoundry:mainfrom
weichou1229:issue-5172
Jun 9, 2025
Merged

fix: Fix CoreCommand GET /device/all API incorrect totalCount#5174
judehung merged 1 commit intoedgexfoundry:mainfrom
weichou1229:issue-5172

Conversation

@weichou1229
Copy link
Member

Fix CoreCommand GET /device/all API incorrect totalCount

Close #5172

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

New Dependency Instructions (If applicable)

Fix CoreCommand GET /device/all API incorrect totalCount

Close edgexfoundry#5172

Signed-off-by: bruce <weichou1229@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

@weichou1229 weichou1229 requested a review from judehung June 9, 2025 01:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.69%. Comparing base (4970ed1) to head (a4f9a90).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5174   +/-   ##
=======================================
  Coverage   26.69%   26.69%           
=======================================
  Files         278      278           
  Lines       19937    19937           
=======================================
  Hits         5322     5322           
  Misses      13357    13357           
  Partials     1258     1258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@judehung judehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judehung judehung merged commit 7a10d06 into edgexfoundry:main Jun 9, 2025
7 checks passed
@weichou1229 weichou1229 deleted the issue-5172 branch June 19, 2025 03:00
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
…oundry#5174)

Fix CoreCommand GET /device/all API incorrect totalCount

Close edgexfoundry#5172

Signed-off-by: bruce <weichou1229@gmail.com>
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
…oundry#5174)

Fix CoreCommand GET /device/all API incorrect totalCount

Close edgexfoundry#5172

Signed-off-by: Bruce Huang <weichou1229@gmail.com>
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
…oundry#5174)

Fix CoreCommand GET /device/all API incorrect totalCount

Close edgexfoundry#5172

Signed-off-by: Bruce Huang <weichou1229@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Incorrect totalCount When Querying DeviceCoreCommands with Offset

3 participants