Skip to content

fix: Windows path in db init sql#5170

Merged
judehung merged 1 commit intoedgexfoundry:mainfrom
cloudxxx8:issue-5150
Jun 5, 2025
Merged

fix: Windows path in db init sql#5170
judehung merged 1 commit intoedgexfoundry:mainfrom
cloudxxx8:issue-5150

Conversation

@cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Jun 4, 2025

converts a path to the format required for go embed by using '/' as the separator. Close #5150

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

See #5151

converts a path to the format required for go embed by using '/' as the separator.
Close edgexfoundry#5150

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

@cloudxxx8
Copy link
Member Author

This PR is based on the changes in #5151

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 26.69%. Comparing base (5253ece) to head (a7fb413).

Files with missing lines Patch % Lines
internal/pkg/db/postgres/utils.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5170      +/-   ##
==========================================
- Coverage   26.69%   26.69%   -0.01%     
==========================================
  Files         278      278              
  Lines       19935    19937       +2     
==========================================
  Hits         5322     5322              
- Misses      13355    13357       +2     
  Partials     1258     1258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@judehung judehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judehung judehung merged commit 67eb838 into edgexfoundry:main Jun 5, 2025
7 checks passed
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
converts a path to the format required for go embed by using '/' as the separator.
Close edgexfoundry#5150

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
converts a path to the format required for go embed by using '/' as the separator.
Close edgexfoundry#5150

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
converts a path to the format required for go embed by using '/' as the separator.
Close edgexfoundry#5150

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Windows Path Separator Compatibility Issue in getSortedSqlFileNames Function

3 participants