Skip to content

fix: CoreCommand GET /device/all API check profile is empty#5164

Merged
judehung merged 1 commit intoedgexfoundry:mainfrom
weichou1229:issue-5163
May 29, 2025
Merged

fix: CoreCommand GET /device/all API check profile is empty#5164
judehung merged 1 commit intoedgexfoundry:mainfrom
weichou1229:issue-5163

Conversation

@weichou1229
Copy link
Member

CoreCommand GET /device/all API check whether device profile is empty, if empty skip the profile query for the specific device.

Close #5163

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

Run core service and device virtual, and test the API for the device with empty profile name.

New Dependency Instructions (If applicable)

CoreCommand GET /device/all API check whether device profile is empty, if empty skip the profile query for the specific device.

Close edgexfoundry#5163

Signed-off-by: bruce <weichou1229@gmail.com>
@weichou1229 weichou1229 requested a review from judehung May 29, 2025 04:22
@sonarqubecloud
Copy link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.69%. Comparing base (d209f5f) to head (5f2ff0c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5164      +/-   ##
==========================================
+ Coverage   26.61%   26.69%   +0.08%     
==========================================
  Files         278      278              
  Lines       19933    19935       +2     
==========================================
+ Hits         5305     5322      +17     
+ Misses      13375    13355      -20     
- Partials     1253     1258       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@judehung judehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judehung judehung merged commit de361d4 into edgexfoundry:main May 29, 2025
7 checks passed
@weichou1229 weichou1229 deleted the issue-5163 branch May 29, 2025 05:34
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
…ndry#5164)

CoreCommand GET /device/all API check whether device profile is empty, if empty skip the profile query for the specific device.

Close edgexfoundry#5163

Signed-off-by: bruce <weichou1229@gmail.com>
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
…ndry#5164)

CoreCommand GET /device/all API check whether device profile is empty, if empty skip the profile query for the specific device.

Close edgexfoundry#5163

Signed-off-by: bruce <weichou1229@gmail.com>
FelixTing pushed a commit to FelixTing/edgex-go that referenced this pull request Oct 15, 2025
…ndry#5164)

CoreCommand GET /device/all API check whether device profile is empty, if empty skip the profile query for the specific device.

Close edgexfoundry#5163

Signed-off-by: Bruce Huang <weichou1229@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core Command GET /device/all API incorrectly return 404 when a device is not associated with any profile

3 participants