feat: Add proxy to build script for device-usb-service#271
feat: Add proxy to build script for device-usb-service#271presatish merged 1 commit intoedgexfoundry:mainfrom
Conversation
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #271 +/- ##
=====================================
Coverage 4.83% 4.83%
=====================================
Files 8 8
Lines 1283 1283
=====================================
Hits 62 62
Misses 1221 1221 |
| --build-arg http_proxy=$(HTTP_PROXY) \ | ||
| --build-arg https_proxy=$(HTTPS_PROXY) \ | ||
| --build-arg no_proxy=$(NO_PROXY) \ |
There was a problem hiding this comment.
Should these use the lowercase form as well? aka --build-arg http_proxy=$(http_proxy), which i think can just be shortened to --build-arg http_proxy
There was a problem hiding this comment.
I followed what was present in the device-onvif-service, that way the environment variables only need to be set with one format for building both services...
There was a problem hiding this comment.
ok, that seems fair, as long as the documentation matches up, which I believe it does when I reviewed that last week.
presatish
left a comment
There was a problem hiding this comment.
The changes look fine but I am not able to test as it looks like vpn certificate for my linux machine has been expired or has some issues because of which I am unable to test.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Docs PR for proxy
Testing Instructions
Add proxy to docker (ping me for specific proxy setup instructions)
Test onsite or on VPN
Run
make docker, the service should build.New Dependency Instructions (If applicable)