Fix #32, adjusting whitespacemode now flags need for redraw#33
Merged
gamecreature merged 1 commit intoedbee:masterfrom Jun 25, 2017
Merged
Conversation
Unlike other formatting changes, adjustment of the white space mode did not
flag {by calling texteditorconfig::noifyChange()} that a redraw was needed.
This was causing an issue in the downstream Mudlet project where just this
feature could be changed and it was not prompting a refresh of the contents
of an edbee editor widget...
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Member
|
Thank you very much for your contribution |
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jun 28, 2017
Immediate that is in the preview "Editor" widget in the Profile Preference (settings/option) dialog - changes to the main Editor (for all and each profile) are not made until the dialog is closed with a save but as the Editor built into one tab is supposed to be a preview it needs to change as the options are. Note that currently showLineFeeds/Paragraphs is not like the original Qt Text Editor widget - instead it just puts a graphical line between each line of text. I believe it is possible to revise this upstream in the Edbee-lib repository to be more like the LineEnd/Paragraph markings of the original Qt widget but that will take a bit of time to do that I do not have right now. Also note that changing the show tabs / spaces option did not take effect immediately in the Edbee editor widget but I have put forward a bugfix for that which has already been accepted into upstream as: PR edbee/edbee-lib#33 as a fix for: issue edbee/edbee-lib#32 Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
vadi2
pushed a commit
to vadi2/Mudlet
that referenced
this pull request
Jun 28, 2017
* BugFix: make changed showTabs/Spaces & showLineFeed/Paragraphs immediate Immediate that is in the preview "Editor" widget in the Profile Preference (settings/option) dialog - changes to the main Editor (for all and each profile) are not made until the dialog is closed with a save but as the Editor built into one tab is supposed to be a preview it needs to change as the options are. Note that currently showLineFeeds/Paragraphs is not like the original Qt Text Editor widget - instead it just puts a graphical line between each line of text. I believe it is possible to revise this upstream in the Edbee-lib repository to be more like the LineEnd/Paragraph markings of the original Qt widget but that will take a bit of time to do that I do not have right now. Also note that changing the show tabs / spaces option did not take effect immediately in the Edbee editor widget but I have put forward a bugfix for that which has already been accepted into upstream as: PR edbee/edbee-lib#33 as a fix for: issue edbee/edbee-lib#32 Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Revise: ensure all aspects of edbee settings persist on item change During testing I found that previous changes to the edbee widget set in the profile preferences did not stay when a new Mudlet item was selected in the editor and that a theme setting made in that dialog was routed to ALL profiles instead of the active one. The first of these issues I solved by ensuring all of the Font, the Theme and the two global settings for show tabs/spaces and (the currently misused) linefeed/paragraph marks are all set when dlgTriggerEditor::clearDocument(...) was called. The second was fixed by removing the inappropriate (void) mudlet::setEditorTheme(const QString&) method and the SIGNAL signal_editorThemeChanged(QString); the latter was wired up to a lambda method in the dlgTriggerEditor constructor, what it did was needed but only as a method called by (void) dlgProfilePreferences::slot_save_and_exit() which was named (void) dlgTriggerEditor::setThemeAndOtherSettings(const QString &). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike other formatting changes, adjustment of the white space mode did not flag {by calling
texteditorconfig::noifyChange()} that a redraw was needed.This was causing an issue in the downstream Mudlet project where just this feature could be changed and it was not prompting a refresh of the contents of an edbee editor widget...
This addresses issue #32
Signed-off-by: Stephen Lyons slysven@virginmedia.com