Skip to content

fix(src/Element.ts) Element type error#725

Closed
lzxb wants to merge 1 commit intoecomfe:masterfrom
lzxb:patch-1
Closed

fix(src/Element.ts) Element type error#725
lzxb wants to merge 1 commit intoecomfe:masterfrom
lzxb:patch-1

Conversation

@lzxb
Copy link
Copy Markdown
Contributor

@lzxb lzxb commented Feb 24, 2021

Detail see: #724

@pissang
Copy link
Copy Markdown
Contributor

pissang commented Feb 24, 2021

Thanks! Seems getInsideTextFill and getOutsideFill also needs this change.

@lzxb
Copy link
Copy Markdown
Contributor Author

lzxb commented Feb 24, 2021

I tested it. No

@lzxb
Copy link
Copy Markdown
Contributor Author

lzxb commented Feb 24, 2021

I use it to develop a real-time chart, which is very good

@pissang
Copy link
Copy Markdown
Contributor

pissang commented Feb 24, 2021

I mean these methods are similar in design. Their returns should all be nullable.

@lzxb
Copy link
Copy Markdown
Contributor Author

lzxb commented Feb 25, 2021

I see you. Subclass inheritance can be reset to undefined

lzxb added a commit to lzxb/zrender that referenced this pull request Feb 25, 2021
pissang added a commit that referenced this pull request Feb 25, 2021
@pissang pissang closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants