Skip to content

fix(mlflow auth): Strip trailing slashes in server URL#311

Merged
gmertes merged 4 commits into
mainfrom
293-mlflow-auth-login-404
Jun 10, 2026
Merged

fix(mlflow auth): Strip trailing slashes in server URL#311
gmertes merged 4 commits into
mainfrom
293-mlflow-auth-login-404

Conversation

@gmertes

@gmertes gmertes commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

requests 2.34 stopped stripping trailing slashes in URLs. Our mlflow auth constructs URLs as f"{self.url}/{path}". If a user-provided URL contains a trailing slash, the constructed path will have a double slash and fail.

requests<2.34 masked this behaviour. We should strip trailing slashes ourselves.

psf/requests#7315

What issue or task does this change relate to?

#293

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@gmertes gmertes linked an issue Jun 5, 2026 that may be closed by this pull request
@github-project-automation github-project-automation Bot moved this to To be triaged in Anemoi-dev Jun 5, 2026
@github-actions github-actions Bot added tests bug Something isn't working and removed tests labels Jun 5, 2026
@github-actions github-actions Bot added the tests label Jun 5, 2026
cathalobrien
cathalobrien previously approved these changes Jun 10, 2026

@cathalobrien cathalobrien left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-project-automation github-project-automation Bot moved this from To be triaged to For merging in Anemoi-dev Jun 10, 2026
@gmertes gmertes merged commit da64c61 into main Jun 10, 2026
72 checks passed
@gmertes gmertes deleted the 293-mlflow-auth-login-404 branch June 10, 2026 12:49
@github-project-automation github-project-automation Bot moved this from For merging to Done in Anemoi-dev Jun 10, 2026
gmertes pushed a commit that referenced this pull request Jun 10, 2026
🤖 Automated Release PR

This PR was created by `release-please` to prepare the next release.
Once merged:

1. A new version tag will be created
2. A GitHub release will be published
3. The changelog will be updated

Changes to be included in the next release:
---


## [0.5.6](0.5.5...0.5.6)
(2026-06-10)


### Bug Fixes

* **mlflow auth:** Strip trailing slashes in server URL
([#311](#311))
([da64c61](da64c61))

---
> [!IMPORTANT]
> Please do not change the PR title, manifest file, or any other
automatically generated content in this PR unless you understand the
implications. Changes here can break the release process.
> ⚠️ Merging this PR will:
> - Create a new release
> - Trigger deployment pipelines
> - Update package versions

 **Before merging:**
 - Ensure all tests pass
 - Review the changelog carefully
 - Get required approvals

[Release-please
documentation](https://github.com/googleapis/release-please)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

mlflow auth login 404

2 participants