Skip to content

Update Xtext to use ASM 9.9.0#3530

Merged
cdietrich merged 1 commit into
eclipse-xtext:mainfrom
merks:pr-3528
Oct 13, 2025
Merged

Update Xtext to use ASM 9.9.0#3530
cdietrich merged 1 commit into
eclipse-xtext:mainfrom
merks:pr-3528

Conversation

@merks

@merks merks commented Oct 13, 2025

Copy link
Copy Markdown
Contributor
  • Restrict the junit version in the target platform to 5.x dependencies.

Fixes #3525

See also #3528

@cdietrich

Copy link
Copy Markdown
Contributor

also misses change in org.eclipse.xtext.dev-bom/pom.xml

@cdietrich

cdietrich commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

/org.eclipse.xtext.xtext.wizard/src/org/eclipse/xtext/xtext/wizard/TargetPlatformProject.xtend
also has the 0.0.0

so where is the bad one coming from?
or is the problem that 2025-12+I-builds has a mixture of both

@merks

merks commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

My workspace is dirty including that file you mention.

image

I only added the one *.target file change to see if that fixes the jenkins build. Depending on that we can try to move forward.

@merks

merks commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

I think the failing test has already passed in the Jenkins build:

image

I think you are saying that those ranges also need to be here:

image

Of course the other *.target files need this change too:

For #3530 (comment) I think you are saying these version should match exactly the current version is the current latest Orbit aggregation?

Please correct if I got any of that wrong.

@merks

merks commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

so where is the bad one coming from?
or is the problem that 2025-12+I-builds has a mixture of both

I answered that already here in #3528 (comment)

https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/table.html

image

@github-actions

github-actions Bot commented Oct 13, 2025

Copy link
Copy Markdown

Test Results

  6 445 files  + 15    6 445 suites  +15   3h 22m 43s ⏱️ - 1m 22s
 43 212 tests  -  23   42 629 ✅  -  18    581 💤  -  3  2 ❌  - 2 
169 931 runs  +104  167 598 ✅ +111  2 325 💤  - 11  8 ❌ +4 

For more details on these failures, see this check.

Results for commit 0808593. ± Comparison against base commit 1d41d02.

This pull request removes 23 tests.
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf00100
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf00200
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf00400
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf00800
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf01600
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf03200
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf06400
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf12800
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf25600
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf51200
…

♻️ This comment has been updated with latest results.

@LorenzoBettini

Copy link
Copy Markdown
Contributor

My workspace is dirty including that file you mention.

@merks unfortunately some of the dirty files are related to the Xtend compiler and are not to be considered.
We still haven't found a way to avoid that.

- Restrict the junit version in all target platforms to 5.x
dependencies.

Fixes eclipse-xtext#3525
@merks

merks commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

The GHA failures look unrelated to asm and junit changes. Perhaps a change in jdt or the platform? The Jenkins build was successful.

@cdietrich

cdietrich commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

dont know whats broken/changed in platform / jdt that could break AutoEditTest
somehow an enter does no longer auto insert a star

@merks

merks commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

So is this a blocker to merging this PR? It seems to me orthogonal and something that can be dealt with later, time/resource permitting.

@cdietrich

Copy link
Copy Markdown
Contributor

i dont have time or infrastructure to investigate ..

@cdietrich

Copy link
Copy Markdown
Contributor

@LorenzoBettini @szarnekow wdyt?

@cdietrich

Copy link
Copy Markdown
Contributor

have started https://ci.eclipse.org/xtext/job/xtext/job/PR-3530/4/ do see proper test results.
these logs from github are unreadanle and i cannot find the link to the rest report for gh actions anymore

@cdietrich

cdietrich commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

it looks like its broken at least since the 9th
https://ci.eclipse.org/xtext/job/xtext/job/main/2450/

update: 8th
https://ci.eclipse.org/xtext/job/xtext/job/cd_tycho50/935/

@LorenzoBettini

Copy link
Copy Markdown
Contributor

This is the original bug related to those failing tests: https://bugs.eclipse.org/bugs/show_bug.cgi?id=453205

Can we ask someone from platform?

@cdietrich

Copy link
Copy Markdown
Contributor

looking at platform.ui log did not spot anything obvious

@merks

merks commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

FYI, test results are here:

image

https://github.com/eclipse-xtext/xtext/pull/3530/checks?check_run_id=52627697324

image

It seems relatively readable if somewhat hard to find.

@cdietrich

Copy link
Copy Markdown
Contributor

@cdietrich cdietrich mentioned this pull request Oct 13, 2025
@cdietrich

Copy link
Copy Markdown
Contributor

created #3531

@cdietrich cdietrich merged commit d8e3813 into eclipse-xtext:main Oct 13, 2025
4 of 9 checks passed
@cdietrich

Copy link
Copy Markdown
Contributor

thx @iloveeclipse @merks

@iloveeclipse do you know about the platform change around projection viewer?

@merks merks deleted the pr-3528 branch October 13, 2025 17:49
xsi:type="jdt:JRETask"
version="JavaSE-17"
location="${jre.location-17}"/>
version="JavaSE-21"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late.

I noted this change in the Oomph configuration.

I personally like it and always use Java 21 in my workspace.

However, I seem to recall that @cdietrich or @szarnekow preferred to stick with Java 17 which is the minimal requirement.

Maybe I don't remember correctly, but just to be sure...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i keep n laptops with different setups to be able to reproduce problems with different tps

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the effect of that version property if you select 2024-03?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldn't hurt but I don't know...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, if the Oomph setup only requires Java 17, one is entitled to specify only a Java 17 JRE, and then, when using one of the latest TPs, most tests won't work and you won't be able to start a runtime workspace.

@merks

merks commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

Given that large parts of the Platform itself are now at Java 21, I'm doubtful that Java 17 launching is workable when using a latest target platform.

Of course one can always added a 17 and set it as the default, for for "latest" I think it needs to be this way.

@cdietrich

Copy link
Copy Markdown
Contributor

no its not
therefor in the old tps/workspaces i use 17 and in the new one 21

@LorenzoBettini

Copy link
Copy Markdown
Contributor

Given that large parts of the Platform itself are now at Java 21, I'm doubtful that Java 17 launching is workable when using a latest target platform.

Of course one can always added a 17 and set it as the default, for for "latest" I think it needs to be this way.

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Xtext to use ASM 9.9.0

4 participants