Update Xtext to use ASM 9.9.0#3530
Conversation
|
also misses change in org.eclipse.xtext.dev-bom/pom.xml |
|
/org.eclipse.xtext.xtext.wizard/src/org/eclipse/xtext/xtext/wizard/TargetPlatformProject.xtend so where is the bad one coming from? |
|
I think the failing test has already passed in the Jenkins build:
I think you are saying that those ranges also need to be here:
Of course the other *.target files need this change too: For #3530 (comment) I think you are saying these version should match exactly the current version is the current latest Orbit aggregation? Please correct if I got any of that wrong. |
I answered that already here in #3528 (comment) https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/table.html
|
Test Results 6 445 files + 15 6 445 suites +15 3h 22m 43s ⏱️ - 1m 22s For more details on these failures, see this check. Results for commit 0808593. ± Comparison against base commit 1d41d02. This pull request removes 23 tests.♻️ This comment has been updated with latest results. |
@merks unfortunately some of the dirty files are related to the Xtend compiler and are not to be considered. |
- Restrict the junit version in all target platforms to 5.x dependencies. Fixes eclipse-xtext#3525
|
The GHA failures look unrelated to asm and junit changes. Perhaps a change in jdt or the platform? The Jenkins build was successful. |
|
dont know whats broken/changed in platform / jdt that could break AutoEditTest |
|
So is this a blocker to merging this PR? It seems to me orthogonal and something that can be dealt with later, time/resource permitting. |
|
i dont have time or infrastructure to investigate .. |
|
@LorenzoBettini @szarnekow wdyt? |
|
have started https://ci.eclipse.org/xtext/job/xtext/job/PR-3530/4/ do see proper test results. |
|
it looks like its broken at least since the 9th update: 8th |
|
This is the original bug related to those failing tests: https://bugs.eclipse.org/bugs/show_bug.cgi?id=453205 Can we ask someone from platform? |
|
looking at platform.ui log did not spot anything obvious |
|
FYI, test results are here: https://github.com/eclipse-xtext/xtext/pull/3530/checks?check_run_id=52627697324
It seems relatively readable if somewhat hard to find. |
|
created #3531 |
|
thx @iloveeclipse @merks @iloveeclipse do you know about the platform change around projection viewer? |
| xsi:type="jdt:JRETask" | ||
| version="JavaSE-17" | ||
| location="${jre.location-17}"/> | ||
| version="JavaSE-21" |
There was a problem hiding this comment.
Sorry for being late.
I noted this change in the Oomph configuration.
I personally like it and always use Java 21 in my workspace.
However, I seem to recall that @cdietrich or @szarnekow preferred to stick with Java 17 which is the minimal requirement.
Maybe I don't remember correctly, but just to be sure...
There was a problem hiding this comment.
i keep n laptops with different setups to be able to reproduce problems with different tps
There was a problem hiding this comment.
what is the effect of that version property if you select 2024-03?
There was a problem hiding this comment.
it shouldn't hurt but I don't know...
There was a problem hiding this comment.
However, if the Oomph setup only requires Java 17, one is entitled to specify only a Java 17 JRE, and then, when using one of the latest TPs, most tests won't work and you won't be able to start a runtime workspace.
|
Given that large parts of the Platform itself are now at Java 21, I'm doubtful that Java 17 launching is workable when using a latest target platform. Of course one can always added a 17 and set it as the default, for for "latest" I think it needs to be this way. |
|
no its not |
I agree. |





Fixes #3525
See also #3528