Test Results

     900 files  ±0       900 suites  ±0   1h 37m 58s ⏱️ + 5m 18s
  7 450 tests ±0    7 294 ✔️ +1  156 💤 ±0  0 ❌  - 1 
23 499 runs  ±0  22 981 ✔️ +1  518 💤 ±0  0 ❌  - 1 

Results for commit 038bbd6. ± Comparison against base commit 2ddad73.

♻️ This comment has been updated with latest results.

If not already done (the change is too big to easily ensure it),can we keep 1 small test with javax.inject to ensure backward-compatibility?

If not already done (the change is too big to easily ensure it),can we keep 1 small test with javax.inject to ensure backward-compatibility?

The org.eclipse.e4.core.tests, which seem to test most of the injector and associated classes are currently still using the javax annotations. My suggestion is to just duplicate all the tests into a second test-plugin org.eclipse.e4.core.javax.tests that duplicates the tests as they are (using javax) and then the 'original' tests are migrated to the jakarta annotations as well.
When removing javax support the project org.eclipse.e4.core.javax.tests can then be deleted too.
But that is the in eclipse.platform and we could completely eclipse.platform.ui.

My suggestion is to just duplicate all the tests into a second test-plugin

Do we really need a seperate plugin or is a dedicated package sufficient?

My suggestion is to just duplicate all the tests into a second test-plugin

Do we really need a seperate plugin or is a dedicated package sufficient?

I'm currently working on making the javax annotations optional and therefore would like to have for the jakarta-annotations tests a test-runtime (at least with Tycho) that does not contain the javax-annotations to verify if that really works.

If not already done (the change is too big to easily ensure it),can we keep 1 small test with javax.inject to ensure backward-compatibility?

The org.eclipse.e4.core.tests, which seem to test most of the injector and associated classes are currently still using the javax annotations. My suggestion is to just duplicate all the tests into a second test-plugin org.eclipse.e4.core.javax.tests that duplicates the tests as they are (using javax) and then the 'original' tests are migrated to the jakarta annotations as well. When removing javax support the project org.eclipse.e4.core.javax.tests can then be deleted too. But that is the in eclipse.platform and we could completely eclipse.platform.ui.

I have now created eclipse-platform/eclipse.platform#791 for that purpose.

I have now created eclipse-platform/eclipse.platform#791 for that purpose.

Thanks!