Add o.e.e4.core.javax.tests as javax-using copy of o.e.e4.core.tests#791
Conversation
2b3d5be to
ea99c24
Compare
ddbeb4c to
917ffb2
Compare
|
What is the opinion from the others about this? It adds quite some lines of code (but since it is a copy of existing Eclipse Code I assume a CQ is not necessary). For #792 the new copied tests already detected a flaw with the handling of provides under javax (which I have to investigate). |
917ffb2 to
4177b01
Compare
|
Yes, I think this critical change and the strong need for backward compatibility really makes the extra code worth it. |
and migrate o.e.e4.core.tests to use jakarta annotations. All test-cases, besides the About-tests, are copied from org.eclipse.e4.core.tests, before the migration of the latter. Consequently o.e.e4.core.javax.tests only differ in the fact that the former uses javax annotations, while the latter uses jakarta annotations. When support for javax annotations is removed from the E4-Injector, o.e.e4.core.javax.tests can be deleted too.
4177b01 to
ed1e24a
Compare
|
Please land it in - we have to be sure that both javax and jakarta works for at least 2 more years (starting from the date we announce javax being deprecated). |
Done. Thank you and Mickael for your partizipation. |
|
@HannesWell where should the jakarta imports come from? I have multiple platform IDEs which all fail to compile because that's not available anywhere, even after triggering Oomph. |
They are in the platform-TP and should be in the I-builds repo. I can check my Installations later this day when I have computer access again. |
|
Note that there are two versions of this bundle and only the 2.x version exports jakarta namespace.
Both are in the resolved target platform:
|
|
Thanks @merks and @HannesWell, I got it working after some more rounds of restart and explicitly triggering Oomph. Not sure what I missed the first time. Sorry for the noise. |
|
No problem! I'm glad you ironed it out... |
and migrate o.e.e4.core.tests to use jakarta-annotations.
All test-cases besides the About-tests are copied from org.eclipse.e4.core.tests
Consequently o.e.e4.core.javax.tests only differ in the fact that the former uses javax-annotations, while the latter uses jakarta-annotations.
When support for javax-annotations is removed from the E4-Injector, o.e.e4.core.javax.tests can be deleted too.