Migrate to javax.inject/annotation provided by Jakarta from Maven-Ctrl.#145
Migrate to javax.inject/annotation provided by Jakarta from Maven-Ctrl.#145HannesWell merged 1 commit intoeclipse-platform:masterfrom HannesWell:javaxAnnotations
Conversation
|
@akurtakov or @mickaelistria can you tell how I have to adjust this PR to make the verification build in eclipse-platform/eclipse.platform.releng.aggregator#1057 (which is modified to include this PR) can succeed? |
|
I don't see jakarta.annotation-api in the target platform https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/eclipse.platform.releng.prereqs.sdk/eclipse-sdk-prereqs.target thus adding it there is the first thing I would try. |
In eclipse-platform/eclipse.platform.releng.aggregator#1057 I added that and for testing changed the .gitmodules file to use my forks master branch, which contains this PR. But still the build fails there with the mentioned error. :/ What I'm not sure about is, if the artifactId needs to be the |
|
Yes, it probably needs to be the bundle name not the artifact ID... |
Its always the bundle symbolic name ... The BSN for https://mvnrepository.com/artifact/jakarta.annotation/jakarta.annotation-api/1.3.5 is:
While the bundle name is:
But the ISV build maybe needs and additional requirement configured to work ... Also keep in mind it might use the I-Builds repository, so you can't use that before it is merged to the target and the master build has deployed the stuff... |
Good point. I think that's the reason for this failure. Anyway, for now I split the replacement of the javax-bundle by jakarta bundles into an addition and removal part and will do the latter after the former is available in an I-build. |
|
Although the overall build in eclipse-platform/eclipse.platform.releng.aggregator#1059 failed, the changed co bundles were build successfully. So I think this is ready to go. |
Part of eclipse-platform/eclipse.platform.releng.aggregator#1056