Remove all javax bundles provided by Eclipse-Orbit#1059
Merged
HannesWell merged 1 commit intoeclipse-platform:masterfrom May 9, 2023
Merged
Remove all javax bundles provided by Eclipse-Orbit#1059HannesWell merged 1 commit intoeclipse-platform:masterfrom
HannesWell merged 1 commit intoeclipse-platform:masterfrom
Conversation
3 tasks
b8b39da to
1eac2c9
Compare
Member
|
Would it be simpler to split javax.xml removal in separat commit ? For the sake of having less reasons for aggregator build failing. |
Remove the unused javax.xml bundle, the modern JREs provide the contained packages by default. Also revert explicit inclusion of jakarta.inject/annotation bundles in eclipse.platform.repository, because they will be transitively included from now on. Part of eclipse-platform#1056
1eac2c9 to
0f7c988
Compare
Member
Author
In general yes, but after searching |
Member
Author
|
It took another round, but now eventually the build succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #1057 to remove the now unused javax.xml bundle, the modern JREs provide the contained packages by default.
Also revert explicit inclusion of jakarta.inject/annotation bundles in eclipse.platform.repository, because they will be transitively included from now on.
Part of #1056
This probably requires the currently running I-build to succeed first (see eclipse-platform/eclipse.platform.common#145 (comment)).