#830 Add module-info to the modules#843
Conversation
jonahgraham
left a comment
There was a problem hiding this comment.
This LGTM, but I would like if a second set of eyes could look as I don't use/write module-info.java as part of my normal work so I don't know what may be needed here.
If there are no objections in a reasonable amount of time I will happily merge as is.
Thank you @Thihup for this contribution.
|
Tested using the $ java --module-path $(find -name "*-SNAPSHOT.jar" -exec echo -n '{}:' \;) --list-modules
...
org.eclipse.lsp4j file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j/build/libs/org.eclipse.lsp4j-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.debug file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.debug/build/libs/org.eclipse.lsp4j.debug-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.generator file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.generator/build/libs/org.eclipse.lsp4j.generator-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.jsonrpc file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.jsonrpc/build/libs/org.eclipse.lsp4j.jsonrpc-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.jsonrpc.debug file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.jsonrpc.debug/build/libs/org.eclipse.lsp4j.jsonrpc.debug-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.websocket file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.websocket/build/libs/org.eclipse.lsp4j.websocket-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.websocket.jakarta file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.websocket.jakarta/build/libs/org.eclipse.lsp4j.websocket.jakarta-0.24.0-SNAPSHOT.jar |
|
Thanks @andirady for the second set of eyes on this. |
|
seems to cause #855 |
|
Thank you @cdietrich for looking into this. I checked out the previous commit (f235e91) and there seems to be no problem with building that version. Thus, the issue has likely something to do with this change. Nevertheless, there seem to be multiple potential causes for the issue I described in #855 (maybe one of: bug in JDT, bug in PDE, bug in buildship, bug in some gradle plug-in, bug in gson library,... in some way related to Java's module system). |
This reverts commit 7ce4f59 which was part of PR eclipse-lsp4j#843 This reversion is being done because the added module info breaks development setup and as of now no one has wanted to pickup the work of having module-info. By reverting this commit we can release 0.24.0 with the same metadata as 0.23.0 was released. Part of eclipse-lsp4j#830
This reverts commit 7ce4f59 which was part of PR #843 This reversion is being done because the added module info breaks development setup and as of now no one has wanted to pickup the work of having module-info. By reverting this commit we can release 0.24.0 with the same metadata as 0.23.0 was released. Part of #830
No description provided.