Skip to content

Add c++20 character types#342

Merged
jonahgraham merged 1 commit intoeclipse-cdt:mainfrom
i-garrison:pr/c++20-character-types
Apr 10, 2023
Merged

Add c++20 character types#342
jonahgraham merged 1 commit intoeclipse-cdt:mainfrom
i-garrison:pr/c++20-character-types

Conversation

@i-garrison
Copy link
Copy Markdown
Contributor

@i-garrison i-garrison commented Mar 27, 2023

This change adds char8_t character type from c++20

@i-garrison i-garrison force-pushed the pr/c++20-character-types branch from d813935 to 256dbe8 Compare March 27, 2023 19:07
@i-garrison i-garrison marked this pull request as draft March 27, 2023 19:10
@i-garrison i-garrison force-pushed the pr/c++20-character-types branch from 256dbe8 to 9981882 Compare March 27, 2023 19:11
@i-garrison i-garrison marked this pull request as ready for review March 27, 2023 19:12
@i-garrison i-garrison force-pushed the pr/c++20-character-types branch 3 times, most recently from 3908f25 to bef1b91 Compare March 29, 2023 16:40
@jonahgraham
Copy link
Copy Markdown
Member

jonahgraham commented Apr 4, 2023

The build on this is failing, best guess is some inlined constant or change of used internals from cdt core has changed causing the failure:

Error:  Failed to execute goal org.eclipse.tycho:tycho-p2-plugin:3.0.3:p2-metadata (baselinereplace-p2-metadata) on project org.eclipse.cdt.ui: baseline and build artifacts have same version but different contents
Error:     no-classifier: different
Error:        org/eclipse/cdt/internal/ui/refactoring/rename/ASTManager.class: different
Error:  -> [Help 1]

It would be nice to know why it has changed, but either way, the version of org.eclipse.cdt.ui needs to be bumped.

@jonahgraham jonahgraham added the language C/C++ Language Support label Apr 4, 2023
@i-garrison
Copy link
Copy Markdown
Contributor Author

i-garrison commented Apr 4, 2023

org.eclipse.cdt.ui needs to be bumped.

Hi @jonahgraham either I bumped the wrong piece in 4411c45 or it did not helped here.

@i-garrison i-garrison force-pushed the pr/c++20-character-types branch from 4411c45 to ad126ce Compare April 4, 2023 19:05
@jonahgraham
Copy link
Copy Markdown
Member

jonahgraham commented Apr 4, 2023

Weird goingson now. The current code passes code cleanliness without the bump, so not sure what is going on and I won't spend much time on that. I will review this later.

@i-garrison
Copy link
Copy Markdown
Contributor Author

i-garrison commented Apr 4, 2023

Well there actually was a bump in Navigator cleanup 47275c3
I just did a rebase onto main and tests are now passing.

@jonahgraham
Copy link
Copy Markdown
Member

jonahgraham commented Apr 4, 2023

Thanks for figuring out what happened.

jonahgraham
jonahgraham reviewed Apr 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. All the changes made seem good. There is still the possibility that some other areas need modification, but I don't have the knowledge to know what may be missing here.

I will make the small change mentioned and submit today for M1.

@jonahgraham jonahgraham force-pushed the pr/c++20-character-types branch from ad126ce to d6c61e9 Compare April 10, 2023 15:19
@jonahgraham jonahgraham merged commit ad15e0e into eclipse-cdt:main Apr 10, 2023
@i-garrison i-garrison deleted the pr/c++20-character-types branch April 11, 2023 00:57
jonahgraham added a commit to jonahgraham/cdt that referenced this pull request Apr 21, 2023
@jonahgraham
Correct since tags on new API for c++20 character types
cdfb2f2 
Fixup for ad15e0e / PR eclipse-cdt#342
@jonahgraham jonahgraham mentioned this pull request Apr 21, 2023
Merged
jonahgraham added a commit that referenced this pull request Apr 21, 2023
@jonahgraham
Correct since tags on new API for c++20 character types
07b03ac 
Fixup for ad15e0e / PR #342
@jonahgraham jonahgraham added this to the 11.2.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

Assignees

No one assigned

Labels

language C/C++ Language Support

Projects

None yet

Milestone

11.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@i-garrison @jonahgraham