make GC3Pie stop build process if a dependency failed (fix for #1441) #2474
Conversation
|
|
||
| # note: order of class inheritance is important! | ||
| class _BuildTaskCollection(AbortOnError, DependentTaskCollection) | ||
| """ |
easybuild/tools/job/gc3pie.py
Outdated
| gc3libs.UNIGNORE_ALL_ERRORS = True | ||
|
|
||
| # note: order of class inheritance is important! | ||
| class _BuildTaskCollection(AbortOnError, DependentTaskCollection) |
|
Also note: requires GC3Pie "master", I think the |
|
@riccardomurri Any ETA for a GC3Pie release that is compatible with this? I'm not sure merging this into an EasyBuild release is wise if it'll require people to run GC3Pie from |
Well, I think I could release 2.5.0 any time -- the planned features are all there. Do you have any deadlines or wishes in this respect? |
|
@riccardomurri EasyBuild v3.6.0 will be released this week, that may be a good time to squeeze this in (although it's very last minute at this point), but then we'd need a GC3Pie release that has what is needed... We should also bump the |
|
Unfortunately I just got a pretty important bug report for GC3Pie "master", so I won't be able to release until I get that fixed. I guess this rules out that EB v3.6.0 comes with GC3Pie 2.5.0... |
|
@riccardomurri OK, we'll postpone this until a future EasyBuild release then, there's no point in including this if there's no GC3Pie release that supports it imho. |
|
@riccardomurri Any updates on a new GC3Pie release which includes what is needed by the changes in this PR? |
|
@boegel I'm testing the fixes -- what's the time line for EB release which should include the new version? |
|
@riccardomurri I'm hoping to release EasyBuild v3.6.1 next week. |
|
@riccardomurri Any progress? |
|
@riccardomurri Ping? Progress on 2.5.0? |
|
Yeah, I've been meaning to release 2.5.0 since a couple of weeks but I can't seem to find the time to handle all the release-based business. I will try to do it by Wednesday -- if not, you can also just pin the GC3Pie by Git commit hash (or I can tag the code if you prefer), there will be no further additions or bugfixes, just packaging and cosmetic changes. |
|
@riccardomurri I would really prefer having a GC3Pie release available before merging this, so we can properly check the GC3Pie version & spit out a meaningful error. With the upcoming EasyBuild 3.7.0 release we have another window of opportunity for this (bumping the GC3Pie requirement in a bugfix release like 3.6.3 or 3.7.1 is a bit awkward). |
|
GC3Pie 2.5.0 was just released: https://pypi.org/project/gc3pie/2.5.0/ Note that a few dependencies were added since the 2.4.2 days:
All of them are |
|
Might also be needed: #2554 |
easybuild/tools/job/gc3pie.py
Outdated
| from gc3libs.core import Engine | ||
| from gc3libs.quantity import hours as hr | ||
| from gc3libs.workflow import DependentTaskCollection | ||
| from gc3libs.workflow import DependentTaskCollection, AbortOnError |
There was a problem hiding this comment.
Please list them in alphabetical order
Changes requested by @akesandgren on PR easybuilders#2474.
This should fix #1441
I have not yet tested it -- please do if you have time.