-
Notifications
You must be signed in to change notification settings - Fork 773
add easyconfig for GAMESS-US #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix this please: proper filename, include the patch, yaddayadda
|
Test PASSed. |
|
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this patch is specific to building GAMESS-US on OS X, it seems...
|
Test report by @boegel |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Test report by @boegel |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Test report by @boegel |
|
Hmm, it seems like the So, leaving this here for now, and going ahead with merging easybuilders/easybuild-easyblocks#558 which does support building/testing on top of |
|
Refer to this link for build results (access rights to CI server needed): |
|
Test report by @boegel |
|
I had to skip the tests in order to make the build pass, since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make it a habit of always adding a line of comment on top of a patch about what it does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right... willing to write a unit test to check that? ;)
|
Refer to this link for build results (access rights to CI server needed): |
|
Test report by @boegel |
|
Jenkins: test this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
Going in now easyblock PR is merged @ easybuilders/easybuild-easyblocks#558 |
|
Thanks for the review @wpoely86! |
depends on easybuilders/easybuild-easyblocks#470depends on easybuilders/easybuild-easyblocks#558