fix(codex): timeouts for websockets#4979
Merged
Merged
Conversation
3e0d875 to
f4f23ad
Compare
|
Do we need to re-open #4945 since it automatically closed? |
hknet
pushed a commit
to hknet/pi-mono
that referenced
this pull request
May 27, 2026
baiyuqing
pushed a commit
to baiyuqing/pi
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not going to fix #4945 but it's a divergence of now codex works. Basically codex forces a connection to time out after a period of inactivity, even if keepalive frames come in. Additionally we now also force a 15 second timeout on connect like codex does.