Skip to content

[21295] Participant discovery data refactor#166

Merged
MiguelCompany merged 1 commit intomainfrom
participant_discovery_data_refactor
Jul 24, 2024
Merged

[21295] Participant discovery data refactor#166
MiguelCompany merged 1 commit intomainfrom
participant_discovery_data_refactor

Conversation

@elianalf
Copy link
Copy Markdown
Contributor

@elianalf elianalf commented Jul 16, 2024 •
edited by MiguelCompany
Loading

Description

This PR removes ParticipantProxyData API, because of the changes applied in Fast DDS PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NO Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v2.0.0 milestone Jul 16, 2024
@elianalf elianalf changed the base branch from main to feature/21301 July 16, 2024 11:03
@elianalf elianalf mentioned this pull request Jul 16, 2024
Merged
11 tasks
Base automatically changed from feature/21301 to main July 17, 2024 05:59
@MiguelCompany MiguelCompany force-pushed the participant_discovery_data_refactor branch from d866b0c to 628522a Compare July 19, 2024 09:10
@MiguelCompany MiguelCompany self-requested a review July 19, 2024 09:36
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 19, 2024
MiguelCompany
MiguelCompany approved these changes Jul 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany self-requested a review July 23, 2024 12:50
@elianalf
Refs #21295: Remove ParticipantProxyData API
055fec9 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the participant_discovery_data_refactor branch from 628522a to 055fec9 Compare July 23, 2024 14:08
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 23, 2024 14:33
@MiguelCompany MiguelCompany merged commit 284d2b0 into main Jul 24, 2024
@MiguelCompany MiguelCompany deleted the participant_discovery_data_refactor branch July 24, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@elianalf @MiguelCompany