Skip to content

Changes to build Fast DDS with XTypes refactor#116

Merged
richiware merged 12 commits into3.0.x-develfrom
feature/remove-cdr
Apr 5, 2024
Merged

Changes to build Fast DDS with XTypes refactor#116
richiware merged 12 commits into3.0.x-develfrom
feature/remove-cdr

Conversation

@JLBuenoLopez
Copy link
Copy Markdown
Contributor

Description

This PR is a miscellaneous containing several changes required to build this package with the Fast DDS branch that refactors XTypes feature.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [NO] Changes are API compatible.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

richiware and others added 9 commits April 3, 2024 07:52
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
…es namespace and DomainId_t

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
…r_from_xml_by_name

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Copy Markdown
Contributor Author

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware force-pushed the feature/remove-cdr branch from 22e90ed to f87af64 Compare April 5, 2024 08:59
@richiware richiware merged commit 8a20026 into 3.0.x-devel Apr 5, 2024
@richiware richiware deleted the feature/remove-cdr branch April 5, 2024 10:58
EduPonz pushed a commit that referenced this pull request May 14, 2024
* Refs #19960. Apply types header-only

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19975. Using new ReturnCode_t

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20129: update TypeInformationParameter constructor. Define xtypes namespace and DomainId_t

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20335: ignore TypeSupport constructor passing a DynamicPubSubType

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20335: regenerate types

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19451: regenerate types

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451: Ignore DomainParticipantFactory::get_dynamic_type_builder_from_xml_by_name

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20734: fixes after rebase

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20734: remove obsolete file

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20734: Fix some tests

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20734. Fix tests

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20734. Regenerate idl dll exporting missing

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants