[20567] Add ReplierQos and RequesterQos#113
Merged
EduPonz merged 2 commits into3.0.x-develfrom Mar 27, 2024
Merged
Conversation
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
9 tasks
elianalf
approved these changes
Mar 26, 2024
Contributor
There was a problem hiding this comment.
LGTM with Green CI, which is running here with the right FastDDS branch
I approved it even though I think we shell remove from the repository all the .i file not included in fastdds.i:
- utils/DBQueue.i
- utils/TimeConversion.i
- utils/StringMatching.i
- Liveliness implementation related API
- rtps/builtin/BuiltinProtocols.i
- rtps/messages/MessageReceiver.i
- utils/Semaphore.i
- All discovery implementation related API
- attributes/SubscriberAttributes.i
- attributes/PublisherAttributes.i
- attributes/RequesterAttributes.i
- attributes/ReplierAttributes.i
- attributes/ParticipantAttributes.i
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Contributor
Author
|
I've applied the suggestions. CI running here |
elianalf
approved these changes
Mar 27, 2024
JLBuenoLopez
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Refs #20567: Add ReplierQos and RequesterQos Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20567: Apply Eliana's suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
May 14, 2024
* Refs #20567: Add ReplierQos and RequesterQos Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20567: Apply Eliana's suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for:
Contributor Checklist
Reviewer Checklist