Skip to content

[20566] Migrate classes from include/fastrtps to fastdds#726

Merged
EduPonz merged 3 commits into3.0.x-develfrom
feature/migrate_classes_from_include_fastrtps
Mar 25, 2024
Merged

[20566] Migrate classes from include/fastrtps to fastdds#726
EduPonz merged 3 commits into3.0.x-develfrom
feature/migrate_classes_from_include_fastrtps

Conversation

@elianalf
Copy link
Copy Markdown
Contributor

@elianalf elianalf commented Mar 12, 2024

Description

This PR migrates the following classes from include/fastrtps to fastdds:

  • IPLocator.h
  • md5.h

Related implementation PR:

Contributor Checklist

  • N/A Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

…to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Copy link
Copy Markdown

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use google include order

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf requested a review from EduPonz March 13, 2024 07:14
@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 13, 2024

@richiprosima please test this

@elianalf
Copy link
Copy Markdown
Contributor Author

@richiprosima please test_3 this

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@EduPonz EduPonz merged commit c46a4d8 into 3.0.x-devel Mar 25, 2024
@EduPonz EduPonz deleted the feature/migrate_classes_from_include_fastrtps branch March 25, 2024 11:30
EduPonz pushed a commit that referenced this pull request Mar 25, 2024
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
richiware pushed a commit that referenced this pull request Apr 18, 2024
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
EduPonz pushed a commit that referenced this pull request Apr 24, 2024
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request May 9, 2024
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
EduPonz pushed a commit that referenced this pull request May 13, 2024
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
EduPonz pushed a commit that referenced this pull request May 14, 2024
* Refs #20566: Migrate classes IPLocator and md5 from include/fastrtps to fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Reorder following google style

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Fix spelling errors after rebase

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants