[23935] Improvements in message receiver by MiguelCompany · Pull Request #6184 · eProsima/Fast-DDS

MiguelCompany · 2025-11-20T11:00:25Z

Description

Ensure all local variables are initialized (address 🧑‍🌾 MessageReceiver fragmentStartingNum may be uninitialized warning #6169)
Change octetsToInlineQos to unsigned.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

mergify · 2025-11-20T22:30:16Z

🧪 CI Insights

Here's what we observed from your CI run for d697529.

❌ Job Failures

Pipeline	Job	Retries	🔍 CI Insights	📄 Logs
`Fast DDS MacOS CI`	`mac-ci / fastdds_test ()`	`0`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, blackbox), v143`	`0`	View	View
	`windows-ci / fastdds_test (RelWithDebInfo, examples), v142`	`0`	View	View
	`windows-ci / fastdds_test (RelWithDebInfo, examples), v143`	`0`	View	View

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

juanlofer-eprosima

Reviewed CI-related commits.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

juanlofer-eprosima

CI changes LGTM

MiguelCompany · 2025-12-01T07:44:59Z

@Mergifyio backport 3.3.x 3.2.x 2.14.x

mergify · 2025-12-01T07:45:15Z

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

#6201 [23935] Improvements in message receiver (backport #6184) has been created for branch 3.3.x but encountered conflicts
#6202 [23935] Improvements in message receiver (backport #6184) has been created for branch 3.2.x but encountered conflicts
#6203 [23935] Improvements in message receiver (backport #6184) has been created for branch 2.14.x but encountered conflicts

* Refs #23935. Small improvements in message receiver. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23935. Avoid copy initialization. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23965. Removing multiplatform actions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Fix documentation job Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 183eae3) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml

* Refs #23935. Small improvements in message receiver. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23935. Avoid copy initialization. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23965. Removing multiplatform actions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Fix documentation job Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 183eae3) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml # src/cpp/rtps/messages/MessageReceiver.cpp

* Refs #23935. Small improvements in message receiver. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23935. Avoid copy initialization. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23965. Removing multiplatform actions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Fix documentation job Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 183eae3) # Conflicts: # .github/workflows/config/tsan.meta # .github/workflows/reusable-ubuntu-ci.yml # .github/workflows/reusable-windows-ci.yml # src/cpp/rtps/messages/MessageReceiver.cpp

* Improvements in message receiver (#6184) * Refs #23935. Small improvements in message receiver. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23935. Avoid copy initialization. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23965. Removing multiplatform actions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Fix documentation job Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 183eae3) # Conflicts: # .github/workflows/config/tsan.meta # .github/workflows/reusable-ubuntu-ci.yml # .github/workflows/reusable-windows-ci.yml # src/cpp/rtps/messages/MessageReceiver.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Add default colcon_args to sanitizers test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Improvements in message receiver (#6184) * Refs #23935. Small improvements in message receiver. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23935. Avoid copy initialization. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23965. Removing multiplatform actions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Fix documentation job Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 183eae3) # Conflicts: # .github/workflows/config/tsan.meta # .github/workflows/reusable-ubuntu-ci.yml # .github/workflows/reusable-windows-ci.yml # src/cpp/rtps/messages/MessageReceiver.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Add default colcon_args to sanitizers test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 2c78c42) # Conflicts: # .github/workflows/reusable-mac-ci.yml # .github/workflows/reusable-ubuntu-ci.yml # src/cpp/rtps/messages/MessageReceiver.cpp

* Improvements in message receiver (#6184) * Refs #23935. Small improvements in message receiver. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23935. Avoid copy initialization. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23965. Removing multiplatform actions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Fix documentation job Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 183eae3) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Add default colcon_args to sanitizers test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Improvements in message receiver (#6184) * Refs #23935. Small improvements in message receiver. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23935. Avoid copy initialization. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23965. Removing multiplatform actions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Fix documentation job Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 183eae3) * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Add default colcon_args to sanitizers test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Improvements in message receiver (#6184) * Refs #23935. Small improvements in message receiver. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23935. Avoid copy initialization. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #23965. Removing multiplatform actions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Fix documentation job Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23965. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 183eae3) # Conflicts: # .github/workflows/reusable-ubuntu-ci.yml # src/cpp/rtps/messages/MessageReceiver.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix conflicts Removed null dereference colcon build step and its cleanup. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Add default colcon_args to sanitizers test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Improvements in message receiver (#6184) * Refs #23935. Small improvements in message receiver. * Refs #23935. Avoid copy initialization. * Refs #23965. Removing multiplatform actions * Refs #23965. Use of CMAKE_CXX_FLAGS_INIT * Refs #23965. Fix documentation job * Refs #23965. Apply suggestions --------- (cherry picked from commit 183eae3) * Fix conflicts * Add default colcon_args to sanitizers test --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany added this to the v3.4.2 milestone Nov 20, 2025

richiware reviewed Nov 20, 2025

View reviewed changes

Comment thread src/cpp/rtps/messages/MessageReceiver.cpp Outdated

MiguelCompany requested a review from richiware November 20, 2025 13:36

github-actions Bot added the ci-pending PR which CI is running label Nov 20, 2025

MiguelCompany force-pushed the hotfix/23935 branch from d4e6a95 to bf68dc0 Compare November 20, 2025 13:40

richiware previously approved these changes Nov 20, 2025

View reviewed changes

MiguelCompany requested review from richiprosima and removed request for richiprosima November 20, 2025 13:42

MiguelCompany force-pushed the hotfix/23935 branch from bf68dc0 to d1a4a1b Compare November 27, 2025 06:53

richiware dismissed their stale review via bf6f4db November 27, 2025 07:09

richiware self-requested a review November 27, 2025 07:10

richiware force-pushed the hotfix/23935 branch from bf6f4db to 952f3d3 Compare November 27, 2025 07:16

richiware requested review from richiware and removed request for richiware November 27, 2025 07:16

MiguelCompany added 2 commits November 27, 2025 08:19

Refs #23935. Small improvements in message receiver.

3bdd1f9

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #23935. Avoid copy initialization.

fe87422

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

richiware force-pushed the hotfix/23935 branch from 952f3d3 to ed75605 Compare November 27, 2025 07:19

richiware requested review from richiware and removed request for richiware November 27, 2025 07:19

richiware self-requested a review November 27, 2025 15:41

richiware mentioned this pull request Nov 28, 2025

[23978] Fix colcon multiplatform actions eProsima/eProsima-CI#166

Merged

5 tasks

richiware added 2 commits November 28, 2025 08:51

Refs #23965. Use of CMAKE_CXX_FLAGS_INIT

4ef69c0

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #23965. Fix documentation job

372c9ec

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware force-pushed the hotfix/23935 branch from eb24d4a to 372c9ec Compare November 28, 2025 07:51

richiware requested review from richiware and removed request for richiware November 28, 2025 07:51

richiware previously approved these changes Nov 28, 2025

View reviewed changes

juanlofer-eprosima requested changes Nov 28, 2025

View reviewed changes

Comment thread .github/workflows/config/asan.meta

Comment thread .github/workflows/config/tsan.meta

Comment thread .github/workflows/reusable-mac-ci.yml

Comment thread .github/workflows/reusable-ubuntu-ci.yml Outdated

Comment thread .github/workflows/reusable-windows-ci.yml

Refs #23965. Apply suggestions

d697529

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware dismissed their stale review via d697529 November 28, 2025 12:29

richiware requested a review from juanlofer-eprosima November 28, 2025 12:30

juanlofer-eprosima approved these changes Dec 1, 2025

View reviewed changes

richiware merged commit 183eae3 into master Dec 1, 2025
24 of 28 checks passed

richiware deleted the hotfix/23935 branch December 1, 2025 06:44

mergify Bot mentioned this pull request Dec 1, 2025

[23935] Improvements in message receiver (backport #6184) #6201

Merged

11 tasks

mergify Bot mentioned this pull request Dec 1, 2025

[23935] Improvements in message receiver (backport #6184) #6202

Merged

11 tasks

mergify Bot mentioned this pull request Dec 1, 2025

[23935] Improvements in message receiver (backport #6184) #6203

Merged

11 tasks

mergify Bot mentioned this pull request Dec 1, 2025

[23935] Improvements in message receiver (backport #6184) (backport #6203) #6205

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[23935] Improvements in message receiver#6184

[23935] Improvements in message receiver#6184
richiware merged 6 commits intomasterfrom
hotfix/23935

MiguelCompany commented Nov 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

mergify Bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

juanlofer-eprosima left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juanlofer-eprosima left a comment

Uh oh!

Uh oh!

MiguelCompany commented Dec 1, 2025

Uh oh!

mergify Bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

MiguelCompany commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

mergify Bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Job Failures

Uh oh!

juanlofer-eprosima left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juanlofer-eprosima left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MiguelCompany commented Dec 1, 2025

Uh oh!

mergify Bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MiguelCompany commented Nov 20, 2025 •

edited

Loading

mergify Bot commented Nov 20, 2025 •

edited

Loading

mergify Bot commented Dec 1, 2025 •

edited

Loading