Skip to content

[23792] Do not export discovery server as cmake target#6089

Merged
richiware merged 1 commit intomasterfrom
bugfix/multiple-discovery-servers
Oct 12, 2025
Merged

[23792] Do not export discovery server as cmake target#6089
richiware merged 1 commit intomasterfrom
bugfix/multiple-discovery-servers

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Oct 9, 2025 •
edited by MiguelCompany
Loading

Description

Do not export discovery server as cmake target

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #23483. Not export discovery server as cmake target
2addb46 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@MiguelCompany MiguelCompany added this to the v3.4.0 - Frozen ❄️ milestone Oct 9, 2025
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Oct 9, 2025
@MiguelCompany MiguelCompany self-requested a review October 9, 2025 10:41
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 9, 2025
@MiguelCompany MiguelCompany removed the no-test Skip CI tests if PR marked with this label label Oct 10, 2025
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany October 10, 2025 06:00
MiguelCompany
MiguelCompany approved these changes Oct 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2025

🧪 CI Insights

Here's what we observed from your CI run for 2addb46.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@richiware richiware merged commit 9418210 into master Oct 12, 2025
39 of 42 checks passed
@richiware richiware deleted the bugfix/multiple-discovery-servers branch October 12, 2025 19:39
@richiware richiware changed the title Do not export discovery server as cmake target [23792] Do not export discovery server as cmake target Oct 13, 2025
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Oct 28, 2025

@Mergifyio backport 3.2.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2025 •
edited
Loading

backport 3.2.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Oct 28, 2025
@richiware @mergify
Not export discovery server as cmake target (#6089)
7434ae8 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 9418210)
@mergify mergify bot mentioned this pull request Oct 28, 2025
Merged
13 tasks
richiware added a commit that referenced this pull request Oct 28, 2025
@richiware
Not export discovery server as cmake target (#6089)
81321ab 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 9418210)
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Oct 28, 2025

@Mergifyio backport 3.3.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2025 •
edited
Loading

backport 3.3.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Oct 28, 2025
@richiware @mergify
Not export discovery server as cmake target (#6089)
6e20420 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 9418210)
@mergify mergify bot mentioned this pull request Oct 28, 2025
Merged
13 tasks
richiware added a commit that referenced this pull request Oct 28, 2025
@richiware
Not export discovery server as cmake target (#6089)
8bd427f 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 9418210)
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany pushed a commit that referenced this pull request Oct 28, 2025
@mergify @richiware
Do not export discovery server as cmake target (#6089) (#6126)
934beb5 
(cherry picked from commit 9418210)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.4.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@richiware @MiguelCompany