[23289] Handle maximum deadline misses case#6016
Merged
juanlofer-eprosima merged 3 commits intoeProsima:masterfrom Oct 10, 2025
Merged
[23289] Handle maximum deadline misses case#6016juanlofer-eprosima merged 3 commits intoeProsima:masterfrom
juanlofer-eprosima merged 3 commits intoeProsima:masterfrom
Conversation
juanlofer-eprosima
requested changes
Sep 15, 2025
Contributor
There was a problem hiding this comment.
Good job! Here are a couple of suggestions:
- Apply same fixes to DataReader
- Make the PR directly from this repo (instead of your fork). Take this into account for the next time, let's keep this PR as it is.
- Reorganize commits
- Bonus: handle 0 lifespan case
zesk1999
commented
Sep 17, 2025
Contributor
Author
zesk1999
left a comment
There was a problem hiding this comment.
The suggestions are applied.
juanlofer-eprosima
requested changes
Sep 19, 2025
Contributor
juanlofer-eprosima
left a comment
There was a problem hiding this comment.
Remember to apply the same fixes to the reader before merging.
juanlofer-eprosima
requested changes
Sep 24, 2025
c7b1a94 to
6602485
Compare
Contributor
🧪 CI InsightsHere's what we observed from your CI run for bc00597. ❌ Job Failures
|
a6a5764 to
ab5f1e7
Compare
ab5f1e7 to
2c44c6b
Compare
2c44c6b to
409716d
Compare
juanlofer-eprosima
requested changes
Oct 3, 2025
juanlofer-eprosima
approved these changes
Oct 9, 2025
Contributor
juanlofer-eprosima
left a comment
There was a problem hiding this comment.
LGTM with greenish CI
Contributor
|
https://github.com/Mergifyio backport 3.3.x 3.2.x 2.14.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # test/blackbox/CMakeLists.txt
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp
This was referenced Oct 10, 2025
zesk1999
added a commit
that referenced
this pull request
Oct 13, 2025
zesk1999
added a commit
that referenced
this pull request
Oct 14, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt
zesk1999
added a commit
that referenced
this pull request
Oct 14, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Oct 15, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt
zesk1999
added a commit
that referenced
this pull request
Oct 15, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp
zesk1999
added a commit
that referenced
this pull request
Oct 15, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp
zesk1999
added a commit
that referenced
this pull request
Oct 15, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Oct 15, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt Co-authored-by: Zeljko Jovanovic <128973134+zesk1999@users.noreply.github.com>
zesk1999
added a commit
that referenced
this pull request
Oct 15, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Oct 16, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp Co-authored-by: Zeljko Jovanovic <128973134+zesk1999@users.noreply.github.com>
Barry-Xu-2018
added a commit
to Barry-Xu-2018/DDS-Pipe
that referenced
this pull request
Oct 17, 2025
eProsima/Fast-DDS#6016 has been merged. So the workaround method is removed. Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
added a commit
to Barry-Xu-2018/DDS-Pipe
that referenced
this pull request
Oct 17, 2025
eProsima/Fast-DDS#6016 has been merged. So the workaround method is removed. Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/Fast-DDS
that referenced
this pull request
Oct 17, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> Co-authored-by: Zeljko Jovanovic <128973134+zesk1999@users.noreply.github.com>
cferreiragonz
pushed a commit
that referenced
this pull request
Nov 17, 2025
* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # test/blackbox/CMakeLists.txt
MiguelCompany
pushed a commit
that referenced
this pull request
Nov 18, 2025
* Handle maximum deadline misses case (#6016) * Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) # Conflicts: # test/blackbox/CMakeLists.txt * Solve conflicts Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Zeljko Jovanovic <128973134+zesk1999@users.noreply.github.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where a DataWriter with a deadline period of 0ms would cause a high CPU load due to an infinite loop of deadline_missed callbacks.
The DataWriterImpl has been modified to handle a 0 as a special case. When this condition is detected:
This ensures that the DataWriter remains stable and responsive, and allows the deadline timer to be properly re-armed if the QoS is later changed to a valid value.
Also, reaching the maximal number of deadline missed messages cancels the timer.
Fixes #23289
@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist