Skip to content

Fix topic argument in Discovery Server example#5996

Merged
MiguelCompany merged 1 commit intomasterfrom
hotfix/fix-ds-example-cli
Sep 4, 2025
Merged

Fix topic argument in Discovery Server example#5996
MiguelCompany merged 1 commit intomasterfrom
hotfix/fix-ds-example-cli

Conversation

@Carlosespicur
Copy link
Copy Markdown
Contributor

@Carlosespicur Carlosespicur commented Sep 2, 2025 •
edited
Loading

Description

This PR fixes the --topic argument in the Discovery Server example to work as expected.

@Mergifyio backport 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Carlosespicur
Fix topic argument in Discovery Server example
7b98e73 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur added this to the v3.4.0 milestone Sep 2, 2025
@Carlosespicur Carlosespicur requested review from richiprosima and removed request for richiprosima September 3, 2025 13:00
@github-actions github-actions Bot added the ci-pending PR which CI is running label Sep 3, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 3, 2025

🧪 CI Insights

Here's what we observed from your CI run for 7b98e73.

🟢 All jobs passed!

But CI Insights is watching 👀

@MiguelCompany MiguelCompany merged commit fd1bb8f into master Sep 4, 2025
27 of 28 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/fix-ds-example-cli branch September 4, 2025 14:58
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Sep 4, 2025

@Mergifyio backport 3.3.x 3.2.x

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 4, 2025 •
edited
Loading

backport 3.3.x 3.2.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Sep 4, 2025
@Carlosespicur @mergify
Fix topic argument in Discovery Server example (#5996)
8051c9d 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit fd1bb8f)
mergify Bot pushed a commit that referenced this pull request Sep 4, 2025
@Carlosespicur @mergify
Fix topic argument in Discovery Server example (#5996)
0286fe5 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit fd1bb8f)
This was referenced Sep 4, 2025
Merged
Merged
MiguelCompany pushed a commit that referenced this pull request Sep 18, 2025
@mergify @Carlosespicur
Fix topic argument in Discovery Server example (#5996) (#6014)
6915359 
(cherry picked from commit fd1bb8f)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Sep 23, 2025
@mergify @Carlosespicur
Fix topic argument in Discovery Server example (#5996) (#6015)
c0a6b6f 
(cherry picked from commit fd1bb8f)

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.4.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@Carlosespicur @MiguelCompany