Skip to content

Revert "Return sample notifying changes on instance state (#5957)"#5973

Merged
MiguelCompany merged 1 commit into2.14.xfrom
hotfix/revert-5957
Aug 1, 2025
Merged

Revert "Return sample notifying changes on instance state (#5957)"#5973
MiguelCompany merged 1 commit into2.14.xfrom
hotfix/revert-5957

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Aug 1, 2025

Description

This reverts commit c8c509c for the same reasons explained in #5968.

Contributor Checklist

  • N/A: Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.14.6 milestone Aug 1, 2025
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Aug 1, 2025

Test CI to replicate failures happening in main for Jazzy: Build Status
Same CI, everything the same, except including this PR: Build Status

@MiguelCompany MiguelCompany merged commit 2a36636 into 2.14.x Aug 1, 2025
5 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/revert-5957 branch August 1, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants