Skip to content

Revert "Return sample notifying changes on instance state (#5943) #5968

Merged
MiguelCompany merged 1 commit intoeProsima:3.2.xfrom
Blast545:3.2.x
Aug 1, 2025
Merged

Revert "Return sample notifying changes on instance state (#5943) #5968
MiguelCompany merged 1 commit intoeProsima:3.2.xfrom
Blast545:3.2.x

Conversation

@Blast545
Copy link
Copy Markdown

@Blast545 Blast545 commented Jul 31, 2025 •
edited
Loading

This reverts commit 0b18cfe.

Description

🧑‍🌾 This PR may have introduced build regressions in ci.ros2.org and build.ros2.org CI. Taking a look in draft mode while I investigate the problem.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Blast545 Blast545 marked this pull request as draft July 31, 2025 20:50
@Blast545 Blast545 marked this pull request as ready for review August 1, 2025 00:30
@Blast545
Copy link
Copy Markdown
Author

Blast545 commented Aug 1, 2025

🧑‍🌾 I tested this on our CI, and it seems to clarify that this PR introduced problems in launch_testing_ros. PTAL, if we can merge this before our weekend that'd be great.

Here are the reference jobs we used to verify that reverting this PR causes ci.ros2.org to be green again:

Test CI to replicate failures happening in main for rolling: Build Status
Same CI, everything the same, except including this PR: Build Status

@Blast545
Revert "Return sample notifying changes on instance state (eProsima#5943
ef15049 
) (eProsima#5956)"

This reverts commit 0b18cfe.

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 mentioned this pull request Aug 1, 2025
Closed
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Aug 1, 2025

Merging this till we investigate further (after vacations).

@MiguelCompany MiguelCompany merged commit d1527be into eProsima:3.2.x Aug 1, 2025
3 of 4 checks passed
@MiguelCompany MiguelCompany mentioned this pull request Aug 1, 2025
Merged
9 tasks
@MiguelCompany MiguelCompany added this to the v3.2.3 - Frozen ❄️ milestone Nov 12, 2025
@MiguelCompany MiguelCompany mentioned this pull request Jan 26, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.2.3 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@Blast545 @MiguelCompany