Skip to content

[23531] Add --quiet to git submodule invocations#5944

Merged
MiguelCompany merged 1 commit intomasterfrom
hotfix/23521
Jul 21, 2025
Merged

[23531] Add --quiet to git submodule invocations#5944
MiguelCompany merged 1 commit intomasterfrom
hotfix/23521

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jul 21, 2025

Description

When forcing third-party usage with -DTHIRPARTY_xxx=FORCE, the Fast DDS build succeeds but leaves traces from the progress of git submodule update commands in stderr.

This PR fixes that by leveraging the --quiet option, so only error messages are printed to stderr.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.4.0 milestone Jul 21, 2025
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Jul 21, 2025
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jul 21, 2025
@MiguelCompany MiguelCompany removed the request for review from richiprosima July 21, 2025 10:39
@MiguelCompany MiguelCompany merged commit 921ca34 into master Jul 21, 2025
17 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/23521 branch July 21, 2025 13:01
@MiguelCompany
Copy link
Copy Markdown
Member Author

@Mergifyio backport 3.3.x 3.2.x 2.14.x

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 21, 2025

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jul 21, 2025
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 921ca34)
mergify Bot pushed a commit that referenced this pull request Jul 21, 2025
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 921ca34)
mergify Bot pushed a commit that referenced this pull request Jul 21, 2025
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 921ca34)
rsanchez15 pushed a commit that referenced this pull request Jul 22, 2025
(cherry picked from commit 921ca34)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jul 22, 2025
(cherry picked from commit 921ca34)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jul 22, 2025
(cherry picked from commit 921ca34)

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants