Skip to content

[23268] Add methods for TypeObject registration of RPC types#5889

Merged
rsanchez15 merged 6 commits intomasterfrom
feature/23268
Jun 26, 2025
Merged

[23268] Add methods for TypeObject registration of RPC types#5889
rsanchez15 merged 6 commits intomasterfrom
feature/23268

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jun 19, 2025 •
edited by rsanchez15
Loading

Description

This adds methods to register the TypeObject of RPC exceptions and related types.
It is necessary in order to generate TypeObject registration of generated RPC request and reply types in Fast DDS Gen.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.3.0 milestone Jun 19, 2025
@MiguelCompany MiguelCompany mentioned this pull request Jun 19, 2025
Merged
6 tasks
@MiguelCompany MiguelCompany force-pushed the feature/23268 branch 2 times, most recently from e61a622 to c319853 Compare June 20, 2025 11:00
@rsanchez15 rsanchez15 requested a review from Carlosespicur June 23, 2025 07:00
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 23, 2025
Carlosespicur
Carlosespicur suggested changes Jun 23, 2025
View reviewed changes
Comment thread include/fastdds/dds/rpc/RPCTypeObjectSupport.hpp Outdated
Carlosespicur
Carlosespicur suggested changes Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Carlosespicur Carlosespicur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should add the changes to versions.md

MiguelCompany and others added 6 commits June 25, 2025 15:05
@MiguelCompany
Refs #23268. Add methods for TypeObject registration of RPC types.
3bf8736 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23268. Add documentation regarding auto-generated code.
d58b581 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23268. Linters.
df827a2 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23268. RPC types are final.
80f8cc0 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @Carlosespicur
Apply suggestion
739f330 
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23268. Update versions.md
566d37b 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@rsanchez15 rsanchez15 merged commit d1545d1 into master Jun 26, 2025
21 of 22 checks passed
@rsanchez15 rsanchez15 deleted the feature/23268 branch June 26, 2025 13:53
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Sep 23, 2025

@Mergifyio backport 3.2.x

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 23, 2025 •
edited
Loading

backport 3.2.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Sep 23, 2025
@MiguelCompany @mergify
Add methods for TypeObject registration of RPC types (#5889)
f968207 
* Refs #23268. Add methods for TypeObject registration of RPC types.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23268. Add documentation regarding auto-generated code.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23268. Linters.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23268. RPC types are final.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Apply suggestion

Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23268. Update versions.md

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
(cherry picked from commit d1545d1)

# Conflicts:
#	versions.md
@mergify mergify Bot mentioned this pull request Sep 23, 2025
Merged
11 tasks
MiguelCompany added a commit that referenced this pull request Sep 24, 2025
@mergify @MiguelCompany
Add methods for TypeObject registration of RPC types (#5889) (#6056)
d333311 
* Add methods for TypeObject registration of RPC types (#5889)

* Refs #23268. Add methods for TypeObject registration of RPC types.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23268. Add documentation regarding auto-generated code.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23268. Linters.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23268. RPC types are final.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Apply suggestion

Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23268. Update versions.md

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
(cherry picked from commit d1545d1)

# Conflicts:
#	versions.md

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Carlosespicur Carlosespicur Carlosespicur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@MiguelCompany @Carlosespicur @rsanchez15