Skip to content

[23340] Fix build on QNX#5871

Merged
MiguelCompany merged 2 commits intomasterfrom
bugfix/23339
Jun 18, 2025
Merged

[23340] Fix build on QNX#5871
MiguelCompany merged 2 commits intomasterfrom
bugfix/23339

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jun 13, 2025 •
edited by Mario-DL
Loading

Description

This fixes the build on QNX reported in #5865. I have only checked it in master and 3.2.x, so the backport to 2.14.x might need some rework.

Note: changes to the asio patch have mostly been taken from this commit

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

MiguelCompany and others added 2 commits June 13, 2025 10:15
@MiguelCompany
Refs #23339. Update QNX patches
4590adb 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #23339. Fix threading_pthread.ipp
c85a864 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.3.0 milestone Jun 13, 2025
Mario-DL
Mario-DL approved these changes Jun 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked master compilation with QNX SDP 8.0

@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Jun 18, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 18, 2025
@MiguelCompany MiguelCompany merged commit 14dc063 into master Jun 18, 2025
15 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/23339 branch June 18, 2025 10:29
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Jun 18, 2025

@Mergifyio backport 3.2.x 2.14.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 18, 2025 •
edited
Loading

backport 3.2.x 2.14.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jun 18, 2025
@MiguelCompany @mergify
Fix build on QNX (#5871)
6fb6350 
* Refs #23339. Update QNX patches

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #23339. Fix threading_pthread.ipp

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Your Name <you@example.com>
(cherry picked from commit 14dc063)
mergify bot pushed a commit that referenced this pull request Jun 18, 2025
@MiguelCompany @mergify
Fix build on QNX (#5871)
70af3f2 
* Refs #23339. Update QNX patches

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #23339. Fix threading_pthread.ipp

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Your Name <you@example.com>
(cherry picked from commit 14dc063)
This was referenced Jun 18, 2025
Merged
Merged
Mario-DL pushed a commit that referenced this pull request Jun 18, 2025
@MiguelCompany @Mario-DL
Fix build on QNX (#5871)
5b3fc16 
* Refs #23339. Update QNX patches

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #23339. Fix threading_pthread.ipp

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Your Name <you@example.com>
(cherry picked from commit 14dc063)
MiguelCompany added a commit that referenced this pull request Jun 19, 2025
@mergify @MiguelCompany
Fix build on QNX (#5871) (#5882)
83f361e 
* Refs #23339. Update QNX patches



* Refs #23339. Fix threading_pthread.ipp



---------




(cherry picked from commit 14dc063)

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Your Name <you@example.com>
MiguelCompany added a commit that referenced this pull request Jun 30, 2025
@mergify @MiguelCompany @Mario-DL
Fix build on QNX (#5871) (#5883)
ca52317 
* Fix build on QNX (#5871)

* Refs #23339. Update QNX patches

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #23339. Fix threading_pthread.ipp

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Your Name <you@example.com>
(cherry picked from commit 14dc063)

* Fix qnx_asio.patch

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #23340: Linter

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Your Name <you@example.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiprosima richiprosima Awaiting requested review from richiprosima

1 more reviewer

@Mario-DL Mario-DL Mario-DL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Milestone

v3.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @Mario-DL