[23213] Add localhost capability only to UDP & TCP transports#5864
Merged
MiguelCompany merged 3 commits intomasterfrom Jun 11, 2025
Merged
[23213] Add localhost capability only to UDP & TCP transports#5864MiguelCompany merged 3 commits intomasterfrom
MiguelCompany merged 3 commits intomasterfrom
Conversation
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
e78aac3 to
cc9bf8a
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
MiguelCompany
approved these changes
Jun 11, 2025
Member
|
@Mergifyio backport 3.2.x 2.14.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
* Refs #23213: Add regression test Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23213: Only add localhost capability to UDP & TCP transports Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23213: Update failing test Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 401ccad)
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
* Refs #23213: Add regression test Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23213: Only add localhost capability to UDP & TCP transports Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23213: Update failing test Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> (cherry picked from commit 401ccad) # Conflicts: # include/fastdds/rtps/builtin/data/NetworkConfiguration.hpp # src/cpp/CMakeLists.txt # src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp # test/blackbox/common/BlackboxTestsNetworkConf.cpp # test/blackbox/common/DDSBlackboxTestsMonitorService.cpp # test/unittest/dds/publisher/CMakeLists.txt # test/unittest/rtps/discovery/CMakeLists.txt # test/unittest/rtps/network/CMakeLists.txt # test/unittest/rtps/reader/CMakeLists.txt # test/unittest/statistics/dds/CMakeLists.txt # test/unittest/statistics/rtps/CMakeLists.txt # test/unittest/transport/CMakeLists.txt
12 tasks
juanlofer-eprosima
added a commit
that referenced
this pull request
Jun 12, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Jun 13, 2025
* Refs #23213: Add regression test * Refs #23213: Only add localhost capability to UDP & TCP transports * Refs #23213: Update failing test --------- (cherry picked from commit 401ccad) Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #3733 introduced a new proxy parameter (network configuration) used to transmit in discovery the information of whether transformation of locators to localhost can be applied for each transport kind. In this parameter, the value of each possible locator kind (powers of 2) is used to conform the binary mask corresponding to the network configuration parameter. However, in PR #5116 the value of shared memory kind was modified in a way that may pollute the values corresponding to UDP transport kinds.
This PR solves the issue by only setting the corresponding localhost network configuration for transports supporting it (UDP and TCP). It also adds an extra assertion verifying the bit operation can be safely done.
@Mergifyio backport 3.2.x 2.14.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist