[22055] Fix unique network flows with TCP transports by cferreiragonz · Pull Request #5461 · eProsima/Fast-DDS

cferreiragonz · 2024-12-05T07:09:22Z

Description

This PR fixes the behavior of Unique Network Flows with TCP transports. When activated, the logical port should be changed instead of modifying the physical port. This allows the communication of participants with TCP transports and the fastdds.unique_network_flows property activated, ensuring that the listening port specified is not modified.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

test/blackbox/common/BlackboxTestsTransportTCP.cpp

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

MiguelCompany

LGTM with green CI

MiguelCompany · 2024-12-11T15:53:27Z

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

mergify · 2024-12-11T15:53:53Z

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

Details

#5486 [22055] Fix unique network flows with TCP transports (backport #5461) has been created for branch 3.1.x
#5487 [22055] Fix unique network flows with TCP transports (backport #5461) has been created for branch 3.0.x
#5488 [22055] Fix unique network flows with TCP transports (backport #5461) has been created for branch 2.14.x
#5489 [22055] Fix unique network flows with TCP transports (backport #5461) has been created for branch 2.10.x but encountered conflicts

* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 81cdb10)

* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 81cdb10) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp

* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 81cdb10) Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Fix unique network flows with TCP transports (#5461) * Refs #22055: Add regression tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 81cdb10) * Solve 2.14 conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #22055: Add regression tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 81cdb10) Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Fix unique network flows with TCP transports (#5461) * Refs #22055: Add regression tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix unique flows for TCP Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22055: Fix tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 81cdb10) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Solve conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

cferreiragonz added 2 commits December 5, 2024 07:55

Refs #22055: Add regression tests

6e89d32

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #22055: Fix unique flows for TCP

d046bdf

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz added needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Dec 5, 2024

cferreiragonz added this to the v3.2.0 milestone Dec 5, 2024

cferreiragonz requested review from MiguelCompany and richiprosima and removed request for richiprosima December 5, 2024 07:09

MiguelCompany requested changes Dec 10, 2024

View reviewed changes

test/blackbox/common/BlackboxTestsTransportTCP.cpp Outdated Show resolved Hide resolved

Refs #22055: Fix tests

9d5f9ba

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz force-pushed the bugfix/tcp_unique_network_flows branch from d981ae8 to 9d5f9ba Compare December 10, 2024 09:18

cferreiragonz requested a review from MiguelCompany December 10, 2024 09:19

MiguelCompany approved these changes Dec 10, 2024

View reviewed changes

MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Dec 11, 2024

MiguelCompany merged commit 81cdb10 into master Dec 11, 2024

MiguelCompany deleted the bugfix/tcp_unique_network_flows branch December 11, 2024 15:51

mergify bot mentioned this pull request Dec 11, 2024

[22055] Fix unique network flows with TCP transports (backport #5461) #5486

Merged

13 tasks

This was referenced Dec 11, 2024

[22055] Fix unique network flows with TCP transports (backport #5461) #5487

Merged

[22055] Fix unique network flows with TCP transports (backport #5461) #5488

Merged

mergify bot mentioned this pull request Dec 11, 2024

[22055] Fix unique network flows with TCP transports (backport #5461) #5489

Merged

13 tasks

cferreiragonz mentioned this pull request Dec 17, 2024

ROS2 jazzy with ROS_DISCOVERY_SERVER and ROS_SUPER_CLIENT [TCP/UDP] 2 PC physical Server and Client ros2 node list - EMPTY by ros2 topic list OK ros2/ros2#1617

Closed

juanlofer-eprosima mentioned this pull request Jan 20, 2025

[22519] Decouple transport receivers creation using unique network flows #5583

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22055] Fix unique network flows with TCP transports#5461

[22055] Fix unique network flows with TCP transports#5461
MiguelCompany merged 3 commits intomasterfrom
bugfix/tcp_unique_network_flows

cferreiragonz commented Dec 5, 2024 •

edited by MiguelCompany

Loading

Uh oh!

Uh oh!

MiguelCompany left a comment

Uh oh!

MiguelCompany commented Dec 11, 2024

Uh oh!

mergify bot commented Dec 11, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cferreiragonz commented Dec 5, 2024 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

MiguelCompany left a comment

Choose a reason for hiding this comment

Uh oh!

MiguelCompany commented Dec 11, 2024

Uh oh!

mergify bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cferreiragonz commented Dec 5, 2024 •

edited by MiguelCompany

Loading

mergify bot commented Dec 11, 2024 •

edited

Loading