[21433] Improve PDPClients initialization by cferreiragonz · Pull Request #5459 · eProsima/Fast-DDS

cferreiragonz · 2024-12-04T14:48:20Z

Description

This PR avoids setting multicast metatraffic locators for PDPClients.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

…IENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz · 2024-12-18T07:31:33Z

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

mergify · 2024-12-18T07:31:54Z

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

Details

#5505 [21433] Improve PDPClients initialization (backport #5459) has been created for branch 3.1.x
#5506 [21433] Improve PDPClients initialization (backport #5459) has been created for branch 3.0.x
#5507 [21433] Improve PDPClients initialization (backport #5459) has been created for branch 2.14.x
#5508 [21433] Improve PDPClients initialization (backport #5459) has been created for branch 2.10.x

* Refs #21433: Add Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Typo Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 451847c)

* Refs #21433: Add Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Typo Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #21433: Add Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Typo Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 451847c) Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #21433: Add Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Typo Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 451847c)

* Improve PDPClients initialization (#5459) * Refs #21433: Add Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Typo Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 451847c) * Fix backport namespaces Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #21433: Add Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Typo Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Improve PDPClients initialization (#5459) * Refs #21433: Add Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CLIENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #21433: Typo Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Fix backport namespaces Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

cferreiragonz added this to the v3.2.0 milestone Dec 4, 2024

cferreiragonz requested review from richiprosima and removed request for richiprosima December 4, 2024 14:48

github-actions bot added the ci-pending PR which CI is running label Dec 4, 2024

cferreiragonz added the needs-review PR that is ready to be reviewed label Dec 5, 2024

cferreiragonz added 3 commits December 10, 2024 10:14

Refs #21433: Add Test

3a326df

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #21433: Avoid using multicast metatraffic for CLIENTS & SUPER_CL…

b067402

…IENTS Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #21433: Typo

3f56028

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz force-pushed the bugfix/improve_clients_init branch from 4654d27 to 3f56028 Compare December 10, 2024 09:14

cferreiragonz requested review from richiprosima and removed request for richiprosima December 11, 2024 07:11

cferreiragonz marked this pull request as ready for review December 11, 2024 15:54

cferreiragonz removed the ci-pending PR which CI is running label Dec 11, 2024

MiguelCompany self-requested a review December 13, 2024 10:06

github-actions bot added the ci-pending PR which CI is running label Dec 13, 2024

MiguelCompany approved these changes Dec 13, 2024

View reviewed changes

MiguelCompany removed the needs-review PR that is ready to be reviewed label Dec 13, 2024

cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Dec 18, 2024

MiguelCompany merged commit 451847c into master Dec 18, 2024

MiguelCompany deleted the bugfix/improve_clients_init branch December 18, 2024 07:43

mergify bot mentioned this pull request Dec 18, 2024

[21433] Improve PDPClients initialization (backport #5459) #5505

Merged

11 tasks

This was referenced Dec 18, 2024

[21433] Improve PDPClients initialization (backport #5459) #5506

Merged

[21433] Improve PDPClients initialization (backport #5459) #5507

Merged

mergify bot mentioned this pull request Dec 18, 2024

[21433] Improve PDPClients initialization (backport #5459) #5508

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21433] Improve PDPClients initialization#5459

[21433] Improve PDPClients initialization#5459
MiguelCompany merged 3 commits intomasterfrom
bugfix/improve_clients_init

cferreiragonz commented Dec 4, 2024 •

edited by MiguelCompany

Loading

Uh oh!

cferreiragonz commented Dec 18, 2024

Uh oh!

mergify bot commented Dec 18, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cferreiragonz commented Dec 4, 2024 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

cferreiragonz commented Dec 18, 2024

Uh oh!

mergify bot commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cferreiragonz commented Dec 4, 2024 •

edited by MiguelCompany

Loading

mergify bot commented Dec 18, 2024 •

edited

Loading