[22033] Release participant_stateless secure builtin writer history change when authentication has finished (backport #5386)#5391
Merged
MiguelCompany merged 1 commit into3.1.xfrom Nov 14, 2024
Conversation
…when authentication has finished (#5386) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621)
14 tasks
MiguelCompany
approved these changes
Nov 14, 2024
cferreiragonz
pushed a commit
that referenced
this pull request
Nov 18, 2024
…when authentication has finished (#5386) (#5391) * TMP: REMOVE THIS COMMIT Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: BB test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Modify secure builtins initial payload size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #22033: Fix: release stateless msg payload pool when participant cryptography succeeds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit b414621) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SecurityManagerdid not ensure thatparticipant_stateless_secure_writerhistory changes were released when the remote participant was authenticated, leading to a high resource utilization.This PR:
participant stateless secure writerhistory to remove the change whenparticipants cryptographysucceeds. In this way we ensure that authentication has finished in both sides. This was important because having authorized the remote is not a sufficient condition to remove the change as the remote may require us to resend until it completes the authentication with us.Addition Notes:
RTPSParticipantAllocationAttributes.@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5386 done by [Mergify](https://mergify.com).