Skip to content

[21997] Rename RTPSParticipantImpl.h to RTPSParticipantImpl.hpp#5356

Merged
MiguelCompany merged 2 commits intomasterfrom
feature/21997
Oct 28, 2024
Merged

[21997] Rename RTPSParticipantImpl.h to RTPSParticipantImpl.hpp#5356
MiguelCompany merged 2 commits intomasterfrom
feature/21997

Conversation

@Mario-DL
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL commented Oct 25, 2024 •
edited by JesusPoderoso
Loading

Description

This PR renamesRTPSPariticipantImpl.h to RTPSParticipantImpl.hpp.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL
Refs #21997: Rename RTPSPariticipantImpl.h to RTPSParticipantImpl.hpp
f36369b 
Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
@Mario-DL
Refs #21997: Update references
cac5273 
Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.2.0 milestone Oct 25, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima October 25, 2024 07:30
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 25, 2024
@rsanchez15 rsanchez15 changed the title [21997] Rename RTPSPariticipantImpl.h to RTPSParticipantImpl.hpp [21997] Rename RTPSParticipantImpl.h to RTPSParticipantImpl.hpp Oct 28, 2024
JesusPoderoso
JesusPoderoso approved these changes Oct 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 28, 2024
@JesusPoderoso
Copy link
Copy Markdown
Contributor

JesusPoderoso commented Oct 28, 2024

@Mergifyio backport 3.1.x 3.0.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 28, 2024 •
edited
Loading

backport 3.1.x 3.0.x

✅ Backports have been created

Details

@MiguelCompany MiguelCompany merged commit dfd651c into master Oct 28, 2024
@MiguelCompany MiguelCompany deleted the feature/21997 branch October 28, 2024 13:35
mergify bot pushed a commit that referenced this pull request Oct 28, 2024
@Mario-DL @mergify
Rename RTPSParticipantImpl.h to RTPSParticipantImpl.hpp (#5356)
af30d57 
* Refs #21997: Rename RTPSPariticipantImpl.h to RTPSParticipantImpl.hpp

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21997: Update references

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
(cherry picked from commit dfd651c)
mergify bot pushed a commit that referenced this pull request Oct 28, 2024
@Mario-DL @mergify
Rename RTPSParticipantImpl.h to RTPSParticipantImpl.hpp (#5356)
0477516 
* Refs #21997: Rename RTPSPariticipantImpl.h to RTPSParticipantImpl.hpp

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21997: Update references

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
(cherry picked from commit dfd651c)
This was referenced Oct 28, 2024
Merged
Merged
MiguelCompany pushed a commit that referenced this pull request Oct 29, 2024
@mergify @Mario-DL
Rename RTPSParticipantImpl.h to RTPSParticipantImpl.hpp (#5356) (#…
887bb85 
…5361)

* Refs #21997: Rename RTPSPariticipantImpl.h to RTPSParticipantImpl.hpp

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21997: Update references

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
(cherry picked from commit dfd651c)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Oct 29, 2024
@mergify @Mario-DL
Rename RTPSParticipantImpl.h to RTPSParticipantImpl.hpp (#5356) (#…
c8c8020 
…5362)

* Refs #21997: Rename RTPSPariticipantImpl.h to RTPSParticipantImpl.hpp

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21997: Update references

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
(cherry picked from commit dfd651c)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v3.2.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@Mario-DL @JesusPoderoso @MiguelCompany