Skip to content

[21335] Fix compilation on VS 2022 in Debug#5040

Merged
EduPonz merged 1 commit intomasterfrom
bugfix/21332
Jul 9, 2024
Merged

[21335] Fix compilation on VS 2022 in Debug#5040
EduPonz merged 1 commit intomasterfrom
bugfix/21332

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Jul 9, 2024

Description

After testing compilation on VS2022, this PR fixes compilation error in Debug.

@Mergifyio backport 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González <ricardo@richiware.dev>
@richiware richiware changed the title Fix compilation on VS 2022 in Debug [21335] Fix compilation on VS 2022 in Debug Jul 9, 2024
@EduPonz EduPonz added this to the v3.0.0 milestone Jul 9, 2024
@EduPonz EduPonz self-requested a review July 9, 2024 07:39
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 9, 2024
@EduPonz
Copy link
Copy Markdown

EduPonz commented Jul 9, 2024

@Mergifyio backport 2.14.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 9, 2024

backport 2.14.x

✅ Backports have been created

Details

@EduPonz EduPonz merged commit dff42e0 into master Jul 9, 2024
@EduPonz EduPonz deleted the bugfix/21332 branch July 9, 2024 12:38
mergify bot pushed a commit that referenced this pull request Jul 9, 2024
Signed-off-by: Ricardo González <ricardo@richiware.dev>
(cherry picked from commit dff42e0)

# Conflicts:
#	src/cpp/rtps/messages/MessageReceiver.cpp
#	tools/fds/server.cpp
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants