Well-known port calculation on endpoint locators [5040]#475
Merged
Well-known port calculation on endpoint locators [5040]#475
Conversation
Member
|
Build status:
|
LuisGP
previously approved these changes
Apr 9, 2019
Contributor
LuisGP
left a comment
There was a problem hiding this comment.
Can be possible to create a common method to avoid dupped code in createWriter and createReader methods?
bb64b16 to
6fadc1b
Compare
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
6fadc1b to
31c24da
Compare
Member
|
Build status:
|
Member
|
Build status:
|
Member
|
Build status:
|
LuisGP
approved these changes
Apr 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables automatic calculation of the port when receiving a value of 0 on the endpoint custom locators.
Signed-off-by: Miguel Company MiguelCompany@eprosima.com