Skip to content

[Hotfix] Structure DynamicType inheritance from TypeObject#4712

Merged
EduPonz merged 2 commits into3.0.x-develfrom
hotfix/dyntype-struct-inheritance-w-typeobject
Apr 24, 2024
Merged

[Hotfix] Structure DynamicType inheritance from TypeObject#4712
EduPonz merged 2 commits into3.0.x-develfrom
hotfix/dyntype-struct-inheritance-w-typeobject

Conversation

@JLBuenoLopez
Copy link
Copy Markdown
Contributor

@JLBuenoLopez JLBuenoLopez commented Apr 22, 2024 •
edited by EduPonz
Loading

Description

This PR fixes a bug in DynamicTypeBuilderFactory::create_type_w_type_object when creating a inheriting structure.

Contributor Checklist

  • [NO] Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez JLBuenoLopez requested a review from richiware April 22, 2024 13:41
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 22, 2024
@JLBuenoLopez
Copy link
Copy Markdown
Contributor Author

JLBuenoLopez commented Apr 22, 2024

@richiprosima please test_3 this

@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 22, 2024

The related regression test should be implemented in #4339

richiware
richiware requested changes Apr 22, 2024
View reviewed changes
@JLBuenoLopez
Hotfix: Struct DynamicType inheritance from TypeObject
fd1b4d6 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Apply review suggestion
d55a370 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez force-pushed the hotfix/dyntype-struct-inheritance-w-typeobject branch from a12fd79 to d55a370 Compare April 23, 2024 09:54
@JLBuenoLopez JLBuenoLopez requested a review from richiware April 23, 2024 09:54
@JLBuenoLopez
Copy link
Copy Markdown
Contributor Author

JLBuenoLopez commented Apr 23, 2024

@richiprosima please test_3 this

@EduPonz EduPonz added this to the v3.0.0 milestone Apr 24, 2024
@EduPonz EduPonz merged commit 4f44922 into 3.0.x-devel Apr 24, 2024
@EduPonz EduPonz deleted the hotfix/dyntype-struct-inheritance-w-typeobject branch April 24, 2024 05:20
@EduPonz EduPonz removed the ci-pending PR which CI is running label Apr 24, 2024
EduPonz pushed a commit that referenced this pull request May 8, 2024
@JLBuenoLopez @EduPonz
Structure DynamicType inheritance from TypeObject (#4712)
8934b35 
* Hotfix: Struct DynamicType inheritance from TypeObject

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Apply review suggestion

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
EduPonz pushed a commit that referenced this pull request May 13, 2024
@JLBuenoLopez @EduPonz
Structure DynamicType inheritance from TypeObject (#4712)
0bdfd83 
* Hotfix: Struct DynamicType inheritance from TypeObject

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Apply review suggestion

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JLBuenoLopez @richiware @EduPonz