Merged
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
MiguelCompany
requested changes
Apr 17, 2024
Member
MiguelCompany
left a comment
There was a problem hiding this comment.
I would also change the order of the comparisons in line 149 to first check for valid, and then check the pid
if (!valid || (pid == PID_SENTINEL))
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
MiguelCompany
approved these changes
Apr 17, 2024
Member
|
@richiprosima Please test this |
Contributor
|
It seems CI issues are unrelated to the PR. |
Member
I should have labeled this as Thanks for this @ahcorde ! |
Member
|
@Mergifyio backport 2.13.x 2.10.x 2.6.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Removed warning Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added suggestions Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 8258507)
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Removed warning Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added suggestions Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 8258507)
This was referenced Apr 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Removed warning Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added suggestions Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 8258507)
EduPonz
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Removed warning Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added suggestions Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 8258507) Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Removed warning Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added suggestions Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 8258507) Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Apr 23, 2024
* Removed warning Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added suggestions Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 8258507) Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new warning on CI https://ci.ros2.org/view/packaging/job/packaging_linux/3405/clang-tidy/folder.112366245/
This should fix the warning