Skip to content

Feature/update doxygen [5013]#465

Merged
richiware merged 2 commits intodevelopfrom
feature/update_doxygen
Apr 26, 2019
Merged

Feature/update doxygen [5013]#465
richiware merged 2 commits intodevelopfrom
feature/update_doxygen

Conversation

@LuisGP
Copy link
Copy Markdown
Contributor

@LuisGP LuisGP commented Mar 27, 2019

No description provided.

@LuisGP LuisGP changed the base branch from master to develop March 27, 2019 10:56
@LuisGP LuisGP changed the title Feature/update doxygen Feature/update doxygen [5013] Mar 27, 2019
@richiware
Copy link
Copy Markdown
Member

richiware commented Mar 28, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Copy Markdown
Member

richiware commented Mar 28, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

richiware
richiware requested changes Apr 11, 2019
View reviewed changes
@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 11, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

richiware
richiware previously approved these changes Apr 11, 2019
View reviewed changes
@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 11, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@LuisGP LuisGP force-pushed the feature/update_doxygen branch from bc402c2 to 6f670c8 Compare April 22, 2019 10:49
@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 22, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

richiware
richiware previously approved these changes Apr 22, 2019
View reviewed changes
@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 22, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

richiware
richiware requested changes Apr 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API was frozen. Don't change from class to struct and don't add const to a function.

@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 23, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@LuisGP
Copy link
Copy Markdown
Contributor Author

LuisGP commented Apr 23, 2019

API was frozen. Don't change from class to struct and don't add const to a function.

Reverted class to struct. The const added to the methods are necessary because it overrides a const method.

Refs #5013 Rebase issues.
5e0752e 
Refs #5013 Requested changes.
Refs #5013 Fixing MAC and Windows Warnings.
Refs #5013 Rebase + Fixes
Requeste changes.
Refs #5014 Applying coding style.
Refs #5011 Update doxyfile file.
Refs #5014 Reviewed and fixed doxygen and coding style.
Refs #5011 Update doxygen
@LuisGP LuisGP force-pushed the feature/update_doxygen branch from 87a37e3 to f764d95 Compare April 26, 2019 06:55
@LuisGP LuisGP force-pushed the feature/update_doxygen branch from f764d95 to 914e02f Compare April 26, 2019 07:10
@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 26, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 26, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware richiware merged commit ef1b397 into develop Apr 26, 2019
@richiware richiware deleted the feature/update_doxygen branch April 26, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LuisGP @richiware