Skip to content

[21188] Example Refactor: Request-Reply #5014

Merged
EduPonz merged 46 commits intomasterfrom
examples/request_reply
Jul 16, 2024
Merged

[21188] Example Refactor: Request-Reply #5014
EduPonz merged 46 commits intomasterfrom
examples/request_reply

Conversation

@EduPonz
Copy link
Copy Markdown

@EduPonz EduPonz commented Jul 1, 2024 •
edited
Loading

Description

This PR refactors the request-reply example.
It also adds a Add DomainParticipantFactory::get_participant_extended_qos_from_default_profile

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jul 1, 2024
@elianalf elianalf changed the title [21188] Request-Reply example [21188] Example Refactor: Request-Reply Jul 1, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Jul 2, 2024
elianalf
elianalf suggested changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@elianalf elianalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.
The include of the subdirectory RequestReplyExample has not been removed from /exampels/cpp/dds/CMakeLists.txt.

elianalf
elianalf suggested changes Jul 3, 2024
View reviewed changes
@elianalf elianalf removed the needs-review PR that is ready to be reviewed label Jul 4, 2024
@EduPonz EduPonz force-pushed the examples/request_reply branch from e120b12 to 05ba0c0 Compare July 10, 2024 12:59
@EduPonz EduPonz requested a review from elianalf July 10, 2024 13:01
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 10, 2024
@EduPonz
Copy link
Copy Markdown
Author

EduPonz commented Jul 11, 2024

All CI except the example's test passed for commit 05ba0c0.

I've increased the timeouts and ask for a manual run on the example's test here

@EduPonz EduPonz force-pushed the examples/request_reply branch from caecb71 to 0002ccb Compare July 12, 2024 08:35
@EduPonz
Copy link
Copy Markdown
Author

EduPonz commented Jul 12, 2024

Another manual CI here

@EduPonz
Copy link
Copy Markdown
Author

EduPonz commented Jul 12, 2024

Another manual try here

elianalf
elianalf suggested changes Jul 15, 2024
View reviewed changes
EduPonz added 16 commits July 15, 2024 15:59
@EduPonz
Refs #21188: Update header guards in other examples
1f80c01 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: CLIParser and example skeleton
59b1233 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add IDL and type support
ea54cea 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add Server initialization
67ec669 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add Server on_subscription_matched
30bbd9c 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add Client initialization
f802cca 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add Client on_publication_matched
7829aed 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Uncrustify
d599241 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Code grouping
7c51b2d 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Refactor matched status and create a utils header
ca43e5c 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Client waits until a server is fully matched
155efc4 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Server runs until it is stopped
8b1075e 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Client sends requests which are put in a queue
5815b8e 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Rename reply z to result
d4b30f3 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Server sends reply and client waits for it
a4bf006 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Move type support to dedicated directory
6473037 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
EduPonz added 23 commits July 15, 2024 15:59
@EduPonz
Refs #21188: Add small TODO for follow-up PR to fulfil
c799e6c 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add context to log messages
d828255 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add tests
e8b09f8 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add README.md
7a3f1cc 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add versions
e3baa96 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Remove old example
412dfe5 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Address minor Eliana's comments
f34ec0f 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Remove operation param from CLI. Client always requests +
d9cf2f5 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add space between doxygen @param and direction specifier
f27a9d8 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Client sends 1 request per operation and waits for all r…
83f2faf 
…eplies

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Fix data race on reader filter removal
d13e20f 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Unmatch participant on participant removed
e327ed7 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Add DomainParticipantFactory::get_participant_extended_q…
6165d9f 
…os_from_default_profile

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Server ignores non-client participants
ec7d224 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Client ignores non-server participants
61869f6 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Improve client log
3b769aa 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Update tests
a82bccc 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Increase timeouts for CI testing
2492375 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Adjust for change in write return type
c0f6687 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Fix data race between requests_status_ init and update
a5898aa 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Take timeouts back to 3s
6a51220 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Remove compose name from clients to cope with different …
a39e041 
…docker compose versions

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21188: Apply Eliana's suggestions
130a911 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the examples/request_reply branch from b32b2b6 to 130a911 Compare July 15, 2024 14:19
@EduPonz EduPonz requested a review from elianalf July 15, 2024 14:19
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 16, 2024
@EduPonz EduPonz removed the ci-pending PR which CI is running label Jul 16, 2024
@EduPonz EduPonz merged commit 0bd9128 into master Jul 16, 2024
@EduPonz EduPonz deleted the examples/request_reply branch July 16, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elianalf elianalf elianalf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@EduPonz @elianalf