Skip to content

Lifespan QoS [4992]#459

Merged
richiware merged 26 commits intodevelopfrom
feature/LifespanQoS
Apr 12, 2019
Merged

Lifespan QoS [4992]#459
richiware merged 26 commits intodevelopfrom
feature/LifespanQoS

Conversation

@raquelalvarezbanos
Copy link
Copy Markdown
Contributor

@raquelalvarezbanos raquelalvarezbanos commented Mar 21, 2019

Implements lifespan QoS. Adds blackbox tests and C++ example.

@richiware
Copy link
Copy Markdown
Member

richiware commented Mar 21, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Copy Markdown
Member

richiware commented Mar 21, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Copy Markdown
Member

richiware commented Mar 22, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@raquelalvarezbanos raquelalvarezbanos changed the title Lifespan QoS [4939] Lifespan QoS [4992] Mar 25, 2019
@richiware
Copy link
Copy Markdown
Member

richiware commented Mar 26, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

richiware
richiware requested changes Mar 26, 2019
View reviewed changes
@richiware
Copy link
Copy Markdown
Member

richiware commented Mar 27, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Copy Markdown
Member

richiware commented Mar 27, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany mentioned this pull request Mar 29, 2019
Closed
31 tasks
richiware
richiware requested changes Mar 30, 2019
View reviewed changes
@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 1, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

richiware
richiware requested changes Apr 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This QoS was not included in the XML reader.

@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 11, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

richiware
richiware previously approved these changes Apr 11, 2019
View reviewed changes
Raquel Alvarez and others added 14 commits April 11, 2019 16:44
Refs #4939 Added TimedCallback class and made changes to participant …
f50616a 
…classes to be able to get the resource event
Refs #4939 Sorting history cache changes by timestamp
b69980c
Refs #4939 Changes to subscriber side
2af400d
Refs #4939 Changing signature of ReaderListener::onNewCacheChangeAdde…
08bbaed 
…d so that the cache change can be removed from the subscriber if is received after it has expired
Refs #4939 Changing RTPSMessageGroup so that if a change has a timest…
52c3bce 
…amp we use that timestamp in INFO_TS submessage
Refs #4939 Changes to subscriber side
37e4db4
Refs #4939 Adding two blackbox tests for lifespan
1da755c
Refs #4939 Changes to subscriber to account for the case where a chan…
9afed4b 
…ge with a timestamp smaller than the earliest change in the history arrives
Refs #4939 Adding a C++ example
5a83b85
Refs #4939 Mutexing SubscriberImpl::lifespan_expired and calling dest…
58e33ce 
…roy() in TimedCallback destructor
Refs #4939 Some fixes and minor changes
e2eb38f
Refs #4939 Using system_clock
c872bdc
Refs #4939 Fixing CI builds
1e93e02
Refs #4939 Fixing some tests that were failing
44b4ea9
Raquel Alvarez added 11 commits April 11, 2019 16:48
Refs #4939 Fixing some warnings
635bc3e
Refs #4939 Taking into account the case where the earliest change in …
006427a 
…the history is not the one that started the timer. This can happen for instance if a change starts the timer but it is later removed from the history
Refs #4992 Applying coding style to lifespan c++ example files
58a5718
Refs #4992 Moving lifespan example readme file to markdown
3a8fe15
Refs #4992 Explicitly setting durability to transient local in C++ ex…
5641f06 
…ample
Refs #4992 Removing unnecessary getter for resource event in participant
c6dff6f
Refs #4992 Moving TimedCallback to a new timedevent/ directory
6ea5917
Refs #4992 Trying to fix mac compiler error
e227952
Refs #4992 Fixing warnings
4bdcbba
Refs #4992 Removing unnecessary forward declaration + changes to XML …
cd8ffd8 
…parser
Refs #4992 Fixing build after rebase
18010b4
@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 11, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 12, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Copy Markdown
Member

richiware commented Apr 12, 2019

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware richiware merged commit ab6fdd0 into develop Apr 12, 2019
@richiware richiware deleted the feature/LifespanQoS branch April 12, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raquelalvarezbanos @richiware