Merged
Conversation
Member
|
Build status:
|
richiware
requested changes
Mar 12, 2019
richiware
requested changes
Mar 13, 2019
Member
|
Build status:
|
richiware
requested changes
Mar 25, 2019
richiware
requested changes
Mar 26, 2019
Member
|
Build status:
|
Member
|
Build status:
|
Member
|
Build status:
|
87bf089 to
11e2f03
Compare
Member
|
Build status:
|
richiware
requested changes
Mar 28, 2019
Member
|
Build status:
|
richiware
previously approved these changes
Mar 29, 2019
4be76ec to
a88c084
Compare
Member
|
Build status:
|
richiware
requested changes
Apr 9, 2019
Member
richiware
left a comment
There was a problem hiding this comment.
This QoS was not included in the XML reader.
Member
|
Build status:
|
richiware
previously approved these changes
Apr 11, 2019
added 7 commits
April 11, 2019 16:20
…a map instead of current vector of pairs
…t so that I can later get the resource event from PublisherImpl and SubscriberImpl
added 5 commits
April 11, 2019 16:26
…hared with LifespanQoS
1b411a2 to
a4e89c6
Compare
Member
|
Build status:
|
Member
|
Build status:
|
Member
|
Build status:
|
…d + removing unnecessary cancel of timer
Member
|
Build status:
|
Member
|
Build status:
|
Member
|
Build status:
|
Member
|
Build status:
|
LuisGP
suggested changes
Apr 15, 2019
LuisGP
previously approved these changes
Apr 15, 2019
Member
|
Build status:
|
LuisGP
reviewed
Apr 15, 2019
Contributor
LuisGP
left a comment
There was a problem hiding this comment.
Found issue [5140] while fixing LivelinessAssertion test.
LuisGP
approved these changes
Apr 15, 2019
Member
|
Build status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Deadline QoS.
Please have a look at the design document in GitLab, which includes the two main approaches discussed. This PR adds the first implementation considered but I also have some commits which I haven't pushed that implement the second approach.