[20227] Prevent index overflow and correctly assert the end iterator in DataSharing by Mario-DL · Pull Request #4321 · eProsima/Fast-DDS

Mario-DL · 2024-01-29T16:50:19Z

Description

When a DataSharing compatible publisher and subscriber were launched at high frequency (publication interval set to 0), it happened two different issues:

The current notified_end of the segment iterator was being updated before being actually checked, making an assert() compare two different versions of this iterator.
On the other hand, unrelated with the previous observation, a corner case of advancing twice the next_payload_ counter could occur.

Apart from the included test, in order to reproduce the first issue it is enough to launch a BasicConfigurationExample with a bounded type and no sleep betweenwrites(). Launching, killing and relaunching the subscriber should trigger the assertion.
For reproducing the second issue, launch the subscriber first and then the publisher, a SIGSEV will be triggered in 20 seconds or so.

This PR includes two fixes that mitigate the problem.
The idea of the test is that if in 20 seconds we have not crashed by some of the above issues, we give the test as passed.

Important note It was noticed that enabling all the verbosity messages in the test, makes the test not work properly under colcon since the timeout notification of the SubscriberModule.cpp condition variable is never fired. It seems that the test stresses the cpu and the timeout notification is lost. However, if the python3 is directly invoked from a terminal (outside colcon), then there is no problem even if all the logs are enabled.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
[X ] Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Mario-DL · 2024-01-30T11:58:12Z

@richiprosima please test linux

Mario-DL · 2024-01-30T11:58:28Z

@richiprosima please test mac

Mario-DL · 2024-01-30T11:58:44Z

@richiprosima please test discovery_server

Mario-DL · 2024-01-30T18:23:46Z

@richiprosima please test mac

EduPonz

NIT not requiring CI

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL · 2024-02-15T06:38:03Z

@richiprosima please test this

EduPonz · 2024-02-16T09:35:29Z

@richiprosima please test mac

Mario-DL · 2024-02-16T13:10:33Z

@richiprosima please test mac

Mario-DL · 2024-02-16T14:16:52Z

@richiprosima please test mac

Mario-DL · 2024-02-19T08:25:48Z

@richiprosima please test mac

Mario-DL · 2024-02-19T13:18:57Z

@richiprosima please test mac

EduPonz · 2024-02-19T14:07:07Z

@richiprosima please test mac

Mario-DL · 2024-02-19T16:30:42Z

@richiprosima please test mac

Mario-DL · 2024-02-19T18:51:17Z

@richiprosima please test mac

JesusPoderoso · 2024-02-20T07:59:03Z

CI issues unrelated to the PR. Ready to merge!

MiguelCompany · 2024-02-20T08:13:58Z

@Mergifyio backport 2.12.x 2.10.x 2.6.x

mergify · 2024-02-20T08:14:06Z

backport 2.12.x 2.10.x 2.6.x

✅ Backports have been created

Details

#4402 [20227] Prevent index overflow and correctly assert the end iterator in DataSharing (backport #4321) has been created for branch 2.12.x
#4403 [20227] Prevent index overflow and correctly assert the end iterator in DataSharing (backport #4321) has been created for branch 2.10.x
#4404 [20227] Prevent index overflow and correctly assert the end iterator in DataSharing (backport #4321) has been created for branch 2.6.x but encountered conflicts

…haring (#4321) * Refs #20227: Add DDS communication test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Prevent history index to overflow history size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Correctly assert the current end Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Initialize test timeout argument properly Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Rev suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 66de89e)

…haring (#4321) (#4403) * Refs #20227: Add DDS communication test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Prevent history index to overflow history size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Correctly assert the current end Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Initialize test timeout argument properly Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Rev suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 66de89e) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>

…haring (#4321) * Refs #20227: Add DDS communication test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Prevent history index to overflow history size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Correctly assert the current end Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Initialize test timeout argument properly Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Rev suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

…haring (#4321) (#4404) * Refs #20227: Add DDS communication test * Refs #20227: Prevent history index to overflow history size * Refs #20227: Correctly assert the current end * Refs #20227: Linter * Refs #20227: Initialize test timeout argument properly * Refs #20227: Rev suggestion --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>

…haring (#4321) (#4402) * Refs #20227: Add DDS communication test Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Prevent history index to overflow history size Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Correctly assert the current end Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Initialize test timeout argument properly Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20227: Rev suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 66de89e) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>

Mario-DL added the ci-pending PR which CI is running label Jan 29, 2024

Mario-DL added this to the v2.13.2 milestone Jan 29, 2024

Mario-DL force-pushed the bugfix/20227 branch from 0be97cb to 88c548e Compare January 29, 2024 18:21

EduPonz modified the milestones: v2.13.2, v2.13.3 Feb 1, 2024

EduPonz suggested changes Feb 14, 2024

View reviewed changes

Comment thread test/dds/communication/SubscriberMain.cpp

Mario-DL added 6 commits February 15, 2024 07:36

Refs #20227: Add DDS communication test

d4d7e68

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20227: Prevent history index to overflow history size

d21ec3c

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20227: Correctly assert the current end

a0e2617

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20227: Linter

209b348

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20227: Initialize test timeout argument properly

b8bd70a

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20227: Rev suggestion

85a6457

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL force-pushed the bugfix/20227 branch from 9c0139e to 85a6457 Compare February 15, 2024 06:37

EduPonz approved these changes Feb 16, 2024

View reviewed changes

JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Feb 20, 2024

MiguelCompany merged commit 66de89e into master Feb 20, 2024

MiguelCompany deleted the bugfix/20227 branch February 20, 2024 08:13

Conversation

Mario-DL commented Jan 29, 2024 • edited by JesusPoderoso Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Mario-DL commented Jan 30, 2024

Uh oh!

Mario-DL commented Jan 30, 2024

Uh oh!

Mario-DL commented Jan 30, 2024

Uh oh!

Mario-DL commented Jan 30, 2024

Uh oh!

EduPonz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Mario-DL commented Feb 15, 2024

Uh oh!

EduPonz commented Feb 16, 2024

Uh oh!

Mario-DL commented Feb 16, 2024

Uh oh!

Mario-DL commented Feb 16, 2024

Uh oh!

Mario-DL commented Feb 19, 2024

Uh oh!

Mario-DL commented Feb 19, 2024

Uh oh!

EduPonz commented Feb 19, 2024

Uh oh!

Mario-DL commented Feb 19, 2024

Uh oh!

Mario-DL commented Feb 19, 2024

Uh oh!

JesusPoderoso commented Feb 20, 2024

Uh oh!

MiguelCompany commented Feb 20, 2024

Uh oh!

mergify Bot commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mario-DL commented Jan 29, 2024 •

edited by JesusPoderoso

Loading

mergify Bot commented Feb 20, 2024 •

edited

Loading