[20351] Fix on_sample_lost notification on best-effort readers for framented samples by MiguelCompany · Pull Request #4187 · eProsima/Fast-DDS

MiguelCompany · 2023-12-21T09:14:24Z

Description

When some fragments are lost on every sample, best-effort readers were not notifying on_sample_lost events.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

JesusPoderoso · 2023-12-24T19:33:24Z

@richiprosima please test this

JesusPoderoso · 2024-01-22T15:44:58Z

Are ASan issues related to the PR? @MiguelCompany

JesusPoderoso · 2024-01-22T15:45:17Z

@richiprosima please test mac 🥲

EduPonz

I have two minor suggestions that IMO can be done without running CI if that passes

test/blackbox/common/DDSBlackboxTestsListeners.cpp

EduPonz · 2024-02-10T13:54:11Z

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

mergify · 2024-02-10T13:54:23Z

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

Details

#4604 [20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) has been created for branch 2.12.x
#4605 [20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) has been created for branch 2.11.x
#4606 [20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) has been created for branch 2.10.x
#4607 [20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) has been created for branch 2.6.x

EduPonz · 2024-02-10T13:54:44Z

@Mergifyio rebase master

mergify · 2024-02-10T13:55:36Z

rebase master

✅ Branch has been successfully rebased

EduPonz · 2024-02-10T13:59:49Z

@richiprosima please test mac test linux test discovery server

JesusPoderoso · 2024-02-14T07:09:31Z

@richiprosima please test mac test linux test discovery server

EduPonz · 2024-02-14T11:25:19Z

@richiprosima please test mac test discovery-server

MiguelCompany · 2024-02-14T14:52:04Z

@richiprosima Please test mac

MiguelCompany · 2024-02-14T15:49:46Z

@richiprosima Please test mac

MiguelCompany · 2024-02-14T15:58:52Z

@richiprosima Please test mac

MiguelCompany · 2024-02-21T07:20:33Z

@Mergifyio rebase

mergify · 2024-02-21T07:20:54Z

rebase

✅ Branch has been successfully rebased

MiguelCompany · 2024-02-21T07:25:10Z

@richiprosima Please test this

MiguelCompany · 2024-03-21T17:09:34Z

@richiprosima please test mac and test windows

EduPonz · 2024-03-22T15:27:18Z

@Mergifyio backport 2.13.x

mergify · 2024-03-22T15:27:47Z

backport 2.13.x

✅ Backports have been created

Details

#4608 [20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) has been created for branch 2.13.x

… samples (#4187) * Refs #20162. Regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Notify sample lost when dropping fragmented change. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20167. Linters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Apply suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Use constexpr for buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Lower buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20351. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5ac198e)

…samples (#4187) (#4606) * Fix on_sample_lost notification on best-effort readers for fragmented samples (#4187) * Refs #20162. Regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Notify sample lost when dropping fragmented change. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20167. Linters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Apply suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Use constexpr for buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Lower buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20351. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5ac198e) * Make sample_lost_be_dw_be_dr_fragments test less flaky (#4620) * Refs #20692. Make sample_lost_be_dw_be_dr_fragments test less flakey. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20692. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Test improvements Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

… samples (#4187) * Refs #20162. Regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Notify sample lost when dropping fragmented change. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20167. Linters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Apply suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Use constexpr for buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Lower buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20351. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5ac198e)

… samples (#4187) (#4608) * Handle errors when setting socket buffer sizes (#4760) (#4796) * Refs #20972. Method socket_buffer_size in DDS_PIM helpers sets also sending buffer. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Method socket_buffer_size in fastrtps_deprecated helpers sets also sending buffer. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Improvements in on_sample_lost blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Move code into new private methods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Refactor on configure_send_buffer_size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Refactor on configure_receive_buffer_size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Check user configuration at the beginning of init method. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Use maxMessageSize as minimum possible value. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Applying changes on OpenAndBindUnicastOutputSocket. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Applying changes on CreateInputChannelResource. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Revert "Refs #20972. Applying changes on CreateInputChannelResource." This reverts commit ed848e9. * Refs #20972. Add helper header with template method. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Configure methods return boolean. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Configure methods use new template method. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. OpenAndBindUnicastOutputSocket uses new template method. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Changes in OpenAndBindInputSocket. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972.Setting options on TCP channels. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Check limits of configured sizes. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Add UDP unit tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Add TCP unit tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Move checks in TCP to beginning of init. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Refactor for common code in UDP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Refactor for common code in TCP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Remove unused constants in UDP tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Check final configuration on unit tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Less strict tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Remove `s_minimumSocketBuffer` from tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Deprecate `s_minimumSocketBuffer`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 53cd211) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/UDPTransportInterface.cpp # src/cpp/rtps/transport/UDPv4Transport.cpp # src/cpp/rtps/transport/UDPv6Transport.cpp # test/blackbox/common/DDSBlackboxTestsListeners.cpp * Refs #21036. Fix conflicts. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21036. Update for non-backported changes Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix on_sample_lost notification on best-effort readers for fragmented samples (#4187) * Refs #20162. Regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Notify sample lost when dropping fragmented change. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20167. Linters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Apply suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Use constexpr for buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Lower buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20351. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5ac198e) * Make sample_lost_be_dw_be_dr_fragments test less flaky (#4620) * Refs #20692. Make sample_lost_be_dw_be_dr_fragments test less flakey. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20692. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Improvements in on_sample_lost blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

… samples (#4187) * Refs #20162. Regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Notify sample lost when dropping fragmented change. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20167. Linters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Apply suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Use constexpr for buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Lower buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20351. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5ac198e)

… samples (#4187) (#4607) * Handle errors when setting socket buffer sizes (#4760) (#4795) * Refs #20972. Move code into new private methods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Refactor on configure_send_buffer_size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Refactor on configure_receive_buffer_size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Check user configuration at the beginning of init method. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Use maxMessageSize as minimum possible value. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Applying changes on OpenAndBindUnicastOutputSocket. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Add helper header with template method. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Configure methods return boolean. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Configure methods use new template method. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. OpenAndBindUnicastOutputSocket uses new template method. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Changes in OpenAndBindInputSocket. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972.Setting options on TCP channels. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Check limits of configured sizes. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Add UDP unit tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Add TCP unit tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Move checks in TCP to beginning of init. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Refactor for common code in UDP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Refactor for common code in TCP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Remove unused constants in UDP tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Check final configuration on unit tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Less strict tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Remove `s_minimumSocketBuffer` from tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20972. Deprecate `s_minimumSocketBuffer`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 532acfa) * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix on_sample_lost notification on best-effort readers for fragmented samples (#4187) * Refs #20162. Regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Notify sample lost when dropping fragmented change. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20167. Linters. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Apply suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Use constexpr for buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20162. Lower buffer size. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20351. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 5ac198e) * Make sample_lost_be_dw_be_dr_fragments test less flaky (#4620) * Refs #20692. Make sample_lost_be_dw_be_dr_fragments test less flakey. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20692. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Improve test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

MiguelCompany added this to the v2.13.1 milestone Dec 21, 2023

MiguelCompany force-pushed the bugfix/20162 branch from dfc6a02 to 58320d3 Compare December 21, 2023 15:52

MiguelCompany modified the milestones: v2.13.1, v2.13.2 Dec 22, 2023

JesusPoderoso added the needs-review PR that is ready to be reviewed label Jan 29, 2024

MiguelCompany changed the title ~~[20167] Fix on_sample_lost notification on best-effort readers for framented samples~~ [20351] Fix on_sample_lost notification on best-effort readers for framented samples Feb 1, 2024

EduPonz suggested changes Feb 10, 2024

View reviewed changes

test/blackbox/common/DDSBlackboxTestsListeners.cpp Outdated Show resolved Hide resolved

test/blackbox/common/DDSBlackboxTestsListeners.cpp Outdated Show resolved Hide resolved

EduPonz force-pushed the bugfix/20162 branch from 58320d3 to 2e71588 Compare February 10, 2024 13:55

EduPonz added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed labels Feb 10, 2024

EduPonz previously approved these changes Feb 14, 2024

View reviewed changes

EduPonz modified the milestones: v2.13.2, v2.13.3 Feb 15, 2024

MiguelCompany force-pushed the bugfix/20162 branch from 6df3ea1 to 25ed51a Compare February 21, 2024 07:20

MiguelCompany added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Mar 22, 2024

EduPonz approved these changes Mar 22, 2024

View reviewed changes

EduPonz merged commit 5ac198e into master Mar 22, 2024

EduPonz deleted the bugfix/20162 branch March 22, 2024 15:26

mergify bot mentioned this pull request Mar 22, 2024

[20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) #4607

Merged

10 tasks

mergify bot mentioned this pull request Mar 22, 2024

[20351] Fix on_sample_lost notification on best-effort readers for framented samples (backport #4187) #4608

Merged

10 tasks

MiguelCompany mentioned this pull request Mar 27, 2024

[20692] Make sample_lost_be_dw_be_dr_fragments test less flakey #4620

Merged

10 tasks

Conversation

MiguelCompany commented Dec 21, 2023 • edited by JesusPoderoso Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

JesusPoderoso commented Dec 24, 2023

Uh oh!

JesusPoderoso commented Jan 22, 2024

Uh oh!

JesusPoderoso commented Jan 22, 2024

Uh oh!

EduPonz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

EduPonz commented Feb 10, 2024

Uh oh!

mergify bot commented Feb 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

EduPonz commented Feb 10, 2024

Uh oh!

mergify bot commented Feb 10, 2024

✅ Branch has been successfully rebased

Uh oh!

EduPonz commented Feb 10, 2024

Uh oh!

JesusPoderoso commented Feb 14, 2024

Uh oh!

EduPonz commented Feb 14, 2024

Uh oh!

MiguelCompany commented Feb 14, 2024

Uh oh!

MiguelCompany commented Feb 14, 2024

Uh oh!

MiguelCompany commented Feb 14, 2024

Uh oh!

MiguelCompany commented Feb 21, 2024

Uh oh!

mergify bot commented Feb 21, 2024

✅ Branch has been successfully rebased

Uh oh!

MiguelCompany commented Feb 21, 2024

Uh oh!

MiguelCompany commented Mar 21, 2024

Uh oh!

EduPonz commented Mar 22, 2024

Uh oh!

mergify bot commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MiguelCompany commented Dec 21, 2023 •

edited by JesusPoderoso

Loading

mergify bot commented Feb 10, 2024 •

edited

Loading

mergify bot commented Mar 22, 2024 •

edited

Loading